From: Greg Banks Subject: Re: [PATCH 22/25] NFS: remove a no-longer-needed error check in nfs_symlink() Date: Thu, 10 Aug 2006 12:10:11 +1000 Message-ID: <1155175810.16378.1254.camel@hole.melbourne.sgi.com> References: <20060809144716.3914.62804.stgit@picasso.dsl.sfldmi.ameritech.net> <20060809145943.3914.99861.stgit@picasso.dsl.sfldmi.ameritech.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Linux NFS Mailing List , Trond Myklebust Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1GB00F-0001EB-EJ for nfs@lists.sourceforge.net; Wed, 09 Aug 2006 19:10:31 -0700 Received: from omx2-ext.sgi.com ([192.48.171.19] helo=omx2.sgi.com) by mail.sourceforge.net with esmtp (Exim 4.44) id 1GB00D-0004Rb-Ot for nfs@lists.sourceforge.net; Wed, 09 Aug 2006 19:10:32 -0700 To: Chuck Lever In-Reply-To: <20060809145943.3914.99861.stgit@picasso.dsl.sfldmi.ameritech.net> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Thu, 2006-08-10 at 00:59, Chuck Lever wrote: > In the early days of NFS, there was no duplicate reply cache on the server. > Thus retransmitted non-idempotent requests often found that the request had > already completed on the server. To avoid passing an unanticipated return > code to unsuspecting applications, NFS clients would often shunt error > codes that implied the request had been retried but already completed. > > On modern NFS clients, it is safe to remove such checks. I'm not sure why you have such faith in servers' repcaches. The Linux knfsd repcache as currently coded is fundamentally useless at modern call rates. If this error case isn't needed anymore it's probably because we have fewer lost calls thanks to using TCP instead of UDP. Greg. -- Greg Banks, R&D Software Engineer, SGI Australian Software Group. I don't speak for SGI. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs