From: Frank Filz <ffilzlnx@us.ibm.com>
Subject: Re: Crash in dec_zone_page_state when nfs_page req is freed
Date: Fri, 13 Oct 2006 08:18:07 -0700
Message-ID: <1160752687.3809.0.camel@dyn9047022153>
References: <1158623736.3376.8.camel@dyn9047022153>
	<1158636275.5896.14.camel@lade.trondhjem.org>
	<1160418641.3376.103.camel@dyn9047022153>
	<1160425510.5466.44.camel@lade.trondhjem.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: NFS List <nfs@lists.sourceforge.net>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
In-Reply-To: <1160425510.5466.44.camel@lade.trondhjem.org>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Mon, 2006-10-09 at 16:25 -0400, Trond Myklebust wrote:
> On Mon, 2006-10-09 at 11:30 -0700, Frank Filz wrote:
> > I've had a chance to do some testing of this. It turns out that
> > nfs_inode_remove_request() will set wb_page to NULL, so it looks like
> > the call to dec_zone_page_state needs to be moved up before
> > nfs_inode_remove_request(). I'm testing that right now, but I start to
> > wonder exactly what the dec_zone_page_state is doing in this case, I
> > know that was a recent addition.
> 
> Yup, that makes sense. Furthermore, it looks like the call to
> nfs_clear_page_writeback is redundant, since nfs_inode_remove_request
> will cause the tags to be implicitly cleared.
> 
> How does the attached patch work for you?

That did the trick. Thanks.

Frank


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs