From: Chris Caputo Subject: Re: NFS hang Date: Mon, 27 Nov 2006 19:33:08 +0000 (GMT) Message-ID: References: <1162840599.31460.8.camel@zod.rchland.ibm.com> <1164655027.5727.5.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Frank Filz , nfs@lists.sourceforge.net, Josh Boyer Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1GomEC-0005ZB-Ul for nfs@lists.sourceforge.net; Mon, 27 Nov 2006 11:33:21 -0800 Received: from nacho.alt.net ([207.14.113.18]) by mail.sourceforge.net with smtp (Exim 4.44) id 1GomEA-00014W-50 for nfs@lists.sourceforge.net; Mon, 27 Nov 2006 11:33:19 -0800 To: Trond Myklebust In-Reply-To: <1164655027.5727.5.camel@lade.trondhjem.org> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Mon, 27 Nov 2006, Trond Myklebust wrote: > On Mon, 2006-11-27 at 19:09 +0000, Chris Caputo wrote: > > - if (!RPC_IS_QUEUED(task)) > > - continue; > > - rpc_clear_running(task); > > + queue = task->u.tk_wait.rpc_waitq; > > NACK... There is no guarantee that task->u.tk_wait has any meaning here. > Particularly not so in the case of an asynchronous task, where the > storage is shared with the work_struct. Yikes. Would you suggest I move the lock outside of the union and try again? Thanks, Chris ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs