From: Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: [PATCH 001 of 4] Copy intr and soft flags to	portmap-bind
	client
Date: Wed, 15 Nov 2006 15:31:26 -0500
Message-ID: <1163622686.5880.1.camel@lade.trondhjem.org>
References: <20061024122646.4426.patches@notabene> <1061024024851.4734@suse.de>
	<76bd70e30610241605x13ae0bamdd306aee2f67d4e1@mail.gmail.com>
	<1163610689.5691.174.camel@lade.trondhjem.org>
	<76bd70e30611151138p1b41c85as5b954ed886051ff2@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: NeilBrown <neilb@suse.de>, Olaf Kirch <okir@suse.de>,
	Chuck Lever <chuck.lever@oracle.com>, nfs@lists.sourceforge.net
To: Chuck Lever <chucklever@gmail.com>
In-Reply-To: <76bd70e30611151138p1b41c85as5b954ed886051ff2@mail.gmail.com>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Wed, 2006-11-15 at 14:38 -0500, Chuck Lever wrote:
> > Hmm... Looking at that code, though there is something that bothers me.
> > Why are we calling pmap_wake_portmap_waiters every time the call to
> > xprt_test_and_set_binding(xprt)!=0? That looks like a nasty bug.
> 
> Well the idea is to make sure the task isn't left on the binding queue
> if pmap_getport can't actually queue an rpcbind request.   I don't
> think it should be waking up all waiters, though -- that part is
> probably wrong.

It shouldn't be waking anybody up if it just failed because a portmapper
request has already been created. In that case, it should just sleep and
wait for the request to finish.


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs