From: Olaf Kirch <okir@suse.de>
Subject: Re: [PATCH 05/12] SUNRPC: Add a function to format the
	address in an svc_rqst for printing
Date: Thu, 9 Nov 2006 11:16:38 +0100
Message-ID: <20061109101638.GB24104@suse.de>
References: <20061101180830.14581.18323.stgit@schiele.dsl.sfldmi.ameritech.net>
	<17746.42034.768127.846582@cse.unsw.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: nfs@lists.sourceforge.net, Chuck Lever <chucklever@gmail.com>
To: Neil Brown <neilb@suse.de>
In-Reply-To: <17746.42034.768127.846582@cse.unsw.edu.au>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Thu, Nov 09, 2006 at 02:44:50PM +1100, Neil Brown wrote:
> > +void svc_print_addr(struct svc_rqst *rqstp, char *buf, size_t len)
> > +{
> > +	__svc_print_addr((struct sockaddr *) &rqstp->rq_addr, buf, len);
> > +
> > +}
> 
> Can we have svc_print_addr take a 
>   char buf[RPC_MAX_ADDRBUFLEN]
> rather than a char* and a len?  The buffer is always the same size, so
> best to hard code it..

The compiler will still let you pass a buf[6] without complaining.
Assumptions that buffer arguments are "big enough" make for great
security bugs two years down the road because people forget.
There's a reason why getwd and gets have been deprecated for 18 years :)

If you want to make it easy, why not have

#define RPC_SVC_ADDR(rqstp, buf) \
	(svc_print_addr(rqstp, buf, sizeof(buf)))

> Also can svc_print_addr return a 'char *' being 'buf'.

That'd be nice.

Olaf
-- 
Walks like a duck. Quacks like a duck. Must be a chicken.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs