From: Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC,PATCH 4/14] knfsd: has_wspace per transport
Date: Wed, 23 May 2007 16:11:38 -0400
Message-ID: <46549FFA.3000409@oracle.com>
References: <20070523023206.GA14076@sgi.com>
	<C27939D4.30F92%tom@opengridcomputing.com>
	<20070523064157.GE14076@sgi.com> <46544377.4090604@oracle.com>
	<20070523143903.GM14076@sgi.com>
Reply-To: chuck.lever@oracle.com
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------030208040202050108020701"
Cc: "Talpey, Thomas" <Thomas.Talpey@netapp.com>,
	NeilBrown <neilb@suse.de>, Peter Leckie <pleckie@melbourne.sgi.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Linux NFS Mailing List <nfs@lists.sourceforge.net>
To: Greg Banks <gnb@sgi.com>
In-Reply-To: <20070523143903.GM14076@sgi.com>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

This is a multi-part message in MIME format.
--------------030208040202050108020701
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Greg Banks wrote:
> On Wed, May 23, 2007 at 09:36:55AM -0400, Chuck Lever wrote:
>> Greg Banks wrote:
>>> On Wed, May 23, 2007 at 12:22:44AM -0500, Tom Tucker wrote:
>>>>
>>>> On 5/22/07 9:32 PM, "Greg Banks" <gnb@sgi.com> wrote:
>>>>
>>>>> On Tue, May 22, 2007 at 12:34:23PM -0500, Tom Tucker wrote:
>>>> I need to do a little clean up (e.g. atomic_inc()) and then I'll add them 
>>>> as
>>>> suggested. If there are dissenters, please speak now...
>>> You should be able to get away with just ++.  They're only stats,
>>> it's not like you have logic depending on them being exact.
>> The usual way to do this is to allocate separate stat arrays for each 
>> CPU.  All the per-CPU arrays are summed only when something wants to 
>> display stat totals.
>>
>> That way you can use ++, be fairly sure you will get accurate 
>> statistics, and not have to be concerned about CPU cache effects or lock 
>> contention.
> 
> Here in SGI, home of the multiple-thousand CPU Linux boxes, making
> data structures per-cpu tends to be done...thoughtfully.
> 
> In any case, the remainder of svc_stat gets no such treatment today.

I based the new NFS client stats on what was done by the networking 
layer, which uses the per-CPU pattern.  I was under the impression that 
methodology was preferred for adding new stat keeping.  But I'm aware 
that the existing NFS client and server stat keeping infrastructure uses 
just a simple array for each RPC program/version.

--------------030208040202050108020701
Content-Type: text/x-vcard; charset=utf-8;
 name="chuck.lever.vcf"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="chuck.lever.vcf"

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel/
version:2.1
end:vcard


--------------030208040202050108020701
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
--------------030208040202050108020701
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

--------------030208040202050108020701--