From: Tom Tucker Subject: Re: [RFC, PATCH 9/15] knfsd: add RDMA debug class to rpc_debug bitfield Date: Sun, 20 May 2007 22:31:15 -0500 Message-ID: References: <20070521031940.GF7482@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: NeilBrown , "Talpey, Thomas" , Linux NFS Mailing List , Peter Leckie To: Greg Banks Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1HpyX7-0000L7-WA for nfs@lists.sourceforge.net; Sun, 20 May 2007 20:26:06 -0700 Received: from mail.es335.com ([67.65.19.105]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1HpyXA-0000it-Jb for nfs@lists.sourceforge.net; Sun, 20 May 2007 20:26:08 -0700 In-Reply-To: <20070521031940.GF7482@sgi.com> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net BTW, Chuck Lever also pointed out that we should probably have a generic RPCDBG_XPRT debug flag instead of RPCDBG_RDMA. I think he's right. I think this should be part of the transport patchset that you're working on. Do you agree? Tom On 5/20/07 10:19 PM, "Greg Banks" wrote: > On Fri, May 18, 2007 at 12:45:45PM -0500, Tom Tucker wrote: >> >> Add a bit to the rpc_debug bit field for RDMA transport >> debug messages and sysctl definitions for configuration >> and statistics files in /proc/sys/sunrpc/svc_rdma. >> >> Signed-off-by: Tom Tucker >> --- >> >> include/linux/sunrpc/debug.h | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h >> index fc3a5dd..9bf7381 100644 >> --- a/include/linux/sunrpc/debug.h >> +++ b/include/linux/sunrpc/debug.h >> @@ -24,6 +24,7 @@ #define RPCDBG_SVCSOCK 0x0100 >> #define RPCDBG_SVCDSP 0x0200 >> #define RPCDBG_MISC 0x0400 >> #define RPCDBG_CACHE 0x0800 >> +#define RPCDBG_RDMA 0x1000 >> #define RPCDBG_ALL 0x7fff > > Fine. Did you update the rpc_debug program in nfs-utils, which also > knows about these debug bits? > >> #ifdef __KERNEL__ >> @@ -93,6 +94,20 @@ enum { >> CTL_RDMA_MAXINLINEWRITE, >> CTL_RDMA_WRITEPADDING, >> CTL_RDMA_MEMREG, >> + CTL_SVCRDMA, >> + CTL_RDMA_MAX_REQUESTS, >> + CTL_RDMA_MAX_REQ_SIZE, >> + CTL_RDMA_ORD, >> + CTL_RDMA_READ_THROTTLE, >> + CTL_RDMA_STAT_RECV, >> + CTL_RDMA_STAT_READ, >> + CTL_RDMA_STAT_WRITE, >> + CTL_RDMA_STAT_SQ_STARVE, >> + CTL_RDMA_STAT_RQ_STARVE, >> + CTL_RDMA_STAT_RQ_POLL, >> + CTL_RDMA_STAT_RQ_PROD, >> + CTL_RDMA_STAT_SQ_POLL, >> + CTL_RDMA_STAT_SQ_PROD >> }; >> >> #endif /* _LINUX_SUNRPC_DEBUG_H_ */ > > This is fine, but one tiny nit: you have the makings of two patches > here. This hunk belongs with the patch that uses the new defines > and registers the sysctls. > > Greg. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs