From: Tom Tucker Subject: Re: [RFC,PATCH 5/14] knfsd: max_payload per transport Date: Thu, 17 May 2007 10:23:06 -0500 Message-ID: <1179415386.23385.5.camel@trinity.ogc.int> References: <20070516192306.GK9626@sgi.com> <17996.12194.801580.925774@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Thomas Talpey , Linux NFS Mailing List , Peter Leckie , Greg Banks To: Neil Brown Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1Hohow-00013K-3V for nfs@lists.sourceforge.net; Thu, 17 May 2007 08:23:14 -0700 Received: from rrcs-71-42-183-126.sw.biz.rr.com ([71.42.183.126] helo=smtp.opengridcomputing.com) by mail.sourceforge.net with esmtp (Exim 4.44) id 1Hohoy-0004cM-Lv for nfs@lists.sourceforge.net; Thu, 17 May 2007 08:23:17 -0700 In-Reply-To: <17996.12194.801580.925774@notabene.brown> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Thu, 2007-05-17 at 20:34 +1000, Neil Brown wrote: > On Thursday May 17, gnb@sgi.com wrote: > > > > Make svc_max_payload() delegate to a new method in svc_sock_ops > > instead of reaching into the socket (beause later the NFS/RDMA > > transport will not even have a socket). > > > > Signed-off-by: Greg Banks > > Signed-off-by: Peter Leckie > .. > > > > +static u32 svc_tcp_max_payload(struct svc_sock *svsk) > > +{ > > + return RPCSVC_MAXPAYLOAD_TCP; > > +} > > + > > Seeing these are implementation (or protocol) defined constants, do we > really need a function call? How about a > int max_payload; > in struct svc_sock_ops?? Or is it tacky to put an integer in a *_ops > structure? I think if we called it a "svc_transport" structure instead of a "svc_sock_ops" structure, it removes the tackiness. It's also more accurate since "svc_sock_ops" implies these are socket ops which they are not. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs