From: Fabio Olive Leite <fleite@redhat.com>
Subject: Re: [PATCH] Attribute timeout handling and wrapping u32
	jiffies
Date: Wed, 25 Jul 2007 11:28:24 -0300
Message-ID: <20070725142824.GA24321@sleipnir.redhat.com>
References: <20070725030809.GB27619@sleipnir.redhat.com>
	<1185372013.6585.73.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
To: linux-nfs <nfs@lists.sourceforge.net>
In-Reply-To: <1185372013.6585.73.camel@localhost>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Wed, Jul 25, 2007 at 10:00:13AM -0400, Trond Myklebust wrote:
> >  =

> > +#define timeout_or_wrap(a,b,c)	\
> > +	(typecheck(unsigned long, a) && \
> > +	 typecheck(unsigned long, b) && \
> > +	 ((a) < (b) || (a) - (b) > (c)))
> > +
> =

> Ugly name. Besides, the above macro causes problems at the wraparound
> boundary when (b) may indeed be < (a), but we're still in the allowed
> range. There is also no guarantee that (c) is unsigned. How about
> =

> #define time_in_range(a,b,c) \
> 	(time_after_eq(a,b) && \
> 	 time_before_eq(a,c))
> =

> instead?

Hmmm (a) is the "current" jiffies, (b) is the "stored" jiffies, and
both are always unsigned long. But (c) is the timeout constant, and I
thought better not to assume typing info there, as a small integer
fits in many types.

I think that in the second check you mean this:

#define time_in_range(a,b,c) \
	(time_after_eq(a,b) && \
	 time_before_eq(a,b+c))

I'll see about testing this new macro in my test box and will report
back soon.

Thanks,
F=E1bio
-- =

ex sed lex awk yacc, e pluribus unix, amem

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs