From: Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC] [PATCH] rpcbind netid declared per-transport
Date: Fri, 31 Aug 2007 11:38:28 -0400
Message-ID: <46D835F4.4030703@oracle.com>
References: <EXNANE01Mb1s7nlT2Nq00000219@exnane01.hq.netapp.com>	
	<46D820F8.6040309@oracle.com>	
	<1188570399.6649.83.camel@heimdal.trondhjem.org>	
	<46D825EB.90801@oracle.com>
	<1188573228.6649.100.camel@heimdal.trondhjem.org>
Reply-To: chuck.lever@oracle.com
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------060401000509030708080603"
Cc: nfs@lists.sourceforge.net,
	"Talpey, Thomas" <Thomas.Talpey@netapp.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
In-Reply-To: <1188573228.6649.100.camel@heimdal.trondhjem.org>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

This is a multi-part message in MIME format.
--------------060401000509030708080603
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Trond Myklebust wrote:
> On Fri, 2007-08-31 at 10:30 -0400, Chuck Lever wrote:
>> Trond Myklebust wrote:
>>> On Fri, 2007-08-31 at 10:08 -0400, Chuck Lever wrote:
>>>
>>>>>  
>>>>> +/*
>>>>> + * RFC1833/RFC3530 rpcbind (v3+) well-known netid's.
>>>>> + */
>>>>> +#define	RPCB_NETID_UDP	"\165\144\160"		/* "udp" */
>>>>> +#define	RPCB_NETID_TCP	"\164\143\160"		/* "tcp" */
>>>>> +#define	RPCB_NETID_UDP6	"\165\144\160\066"	/* "udp6" */
>>>>> +#define	RPCB_NETID_TCP6	"\164\143\160\066"	/* "tcp6" */
>>> BTW: Any reason why we are using escaped octal instead of plain ascii
>>> here?
>> Is there a guarantee that these C strings will be US-ASCII on *every* 
>> platform in every locale on which Linux kernels are built?  Z-series, 
>> for example?
>>
>> If yes, then we can use a normal string.

> You might have somebody convert all the strings in the kernel into
> EBCDIC, just for fun, but that will make the strings unreadable on the
> computer running the resulting kernel ('cos Linux uses ASCII) and would
> likely break all sorts of kernel-userspace interfaces besides breaking
> this little snippet in the rpcbind code.

Well, according to Harbison & Steele, the C source and eventual 
execution character set can be different.  I'm not as certain as you are 
of the guarantee that the Linux kernel environment is US-ASCII on every 
platform from compile to execution.  I've actually written C system 
programs in OpenEdition on MVS/390.

However, if you are comfortable using just a plain old C string (and 
maybe keeping documentation of the US-ASCII requirement in a comment), 
have Tom replace the octal strings with C character strings in his patch.

--------------060401000509030708080603
Content-Type: text/x-vcard; charset=utf-8;
 name="chuck.lever.vcf"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="chuck.lever.vcf"

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


--------------060401000509030708080603
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
--------------060401000509030708080603
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

--------------060401000509030708080603--