From: Trond Myklebust Subject: Re: [PATCH] NFS: fix length computation in nfs_validate_mount_data Date: Wed, 29 Aug 2007 16:40:08 -0400 Message-ID: <1188420008.6580.126.camel@heimdal.trondhjem.org> References: <46D5D774.20908@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: nfs@lists.sourceforge.net To: chuck.lever@oracle.com Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1IQULF-0003wC-78 for nfs@lists.sourceforge.net; Wed, 29 Aug 2007 13:41:31 -0700 Received: from pat.uio.no ([129.240.10.15]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IQULI-00060c-7X for nfs@lists.sourceforge.net; Wed, 29 Aug 2007 13:40:49 -0700 In-Reply-To: <46D5D774.20908@oracle.com> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Wed, 2007-08-29 at 16:30 -0400, Chuck Lever wrote: > Yep, this is the same fix as one provided in the clean-up/bug-fix > patches I just resent today. Sure, but we shouldn't be sending pure cleanups to Linus when we're already in an -rc4 release. OTOH, I'd like to fix genuine bugs like this, so I'll probably send in James' patch for now, and then let the cleanups lie until the 2.6.24 merge window opens. Cheers Trond > James Lentini wrote: > > While experimenting with the new string mount infrastructure, I > > noticed an off by one error in the computation of the hostname's > > length. This patch fixes the length computation to match the same > > computation in nfs4_validate_mount_data(). > > > > Signed-off-by: James Lentini > > --- > > > > fs/nfs/super.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- fs/nfs/super.c 2007-08-29 15:06:59.320932000 -0400 > > +++ fs/nfs/super.c 2007-08-29 15:07:51.439960000 -0400 > > @@ -1153,7 +1153,7 @@ static int nfs_validate_mount_data(struc > > c = strchr(dev_name, ':'); > > if (c == NULL) > > return -EINVAL; > > - len = c - dev_name - 1; > > + len = c - dev_name; > > if (len > sizeof(data->hostname)) > > return -EINVAL; > > strncpy(data->hostname, dev_name, len); > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs