From: Neil Brown <neilb@suse.de>
Subject: Re: [PATCH 0/5] nfsstat: more --diff-stat/--sleep items
Date: Thu, 9 Aug 2007 11:13:45 +1000
Message-ID: <18106.27209.93060.7817@notabene.brown>
References: <Pine.BSO.4.64.0708071928330.26009@citi.umich.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: nfs@lists.sourceforge.net
To: "david m. richter" <richterd@citi.umich.edu>
In-Reply-To: message from david m. richter on Tuesday August 7
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Tuesday August 7, richterd@citi.umich.edu wrote:
> 	Hello, Neil, 
> 
> 	This set of patches fills in some holes from the initial 
> --diff-stat work.  The first patch maybe should be separate, but the third 
> patch makes use of it (but could easily be reworked).
> 
> 
> - patch 1 adds three counters to the client v4 ops display -- GETACL, 
> SETACL, and FS_LOCATIONS, which are available in /proc/net/rpc/nfs but 
> haven't been used.
> 
> - patch 2 adds, at your suggestion, a comment clarifying what has_stats() 
> is actually doing.
> 
> - patch 3 fixes a bug in diff_stats() that causes false-positives in 
> has_stats().
> 
> - patch 4, as Bruce Fields suggested, renames -D/--diff-stat to 
> the (hopefully) more intuitive -Z/--sleep.
> 
> - patch 5 adds -Z/--sleep to the nfsstat manpage.
> 

Thanks.  All applied (after I wraps your comments to 80 columns, and
removed white space at the end of lines).

NeilBrown

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs