From: "david m. richter" Subject: Re: [PATCH 0/7] nfsstat: adding -D/--diff-stat to nfsstat Date: Wed, 1 Aug 2007 14:37:09 -0400 (EDT) Message-ID: References: <46B074A2.4010909@redhat.com><20070801165033.GA13441@fieldses.org><1185990384.6700.188.camel@localhost> <01AE8AF878612047A442668306EAEB05DD298B@SACEXMV01.hq.netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Peter Staubach , Neil Brown , Alex Soule , Trond Myklebust , "J. Bruce Fields" , Andrew Richardson , nfs@lists.sourceforge.net To: "Muntz, Daniel" Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1IGJ4E-0004gs-Mj for nfs@lists.sourceforge.net; Wed, 01 Aug 2007 11:37:06 -0700 Received: from citi.umich.edu ([141.211.133.111]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IGJ4I-0006ae-9U for nfs@lists.sourceforge.net; Wed, 01 Aug 2007 11:37:10 -0700 In-Reply-To: <01AE8AF878612047A442668306EAEB05DD298B@SACEXMV01.hq.netapp.com> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Wed, 1 Aug 2007, Muntz, Daniel wrote: > >perhaps i don't follow: how is zeroing the stats address the same > >use-case as --diff-stat/--sleep? one can already zero the stats > >by unmounting, e.g., but that's a pain. ? i'm missing something. > > i think you're answering your own question. being able to zero the > stats with 'nfsstat -z' allows you to avoid unmounting, while giving you > the ability to, um, zero the stats... instead of being a pain, it's > trivial. did i miss an existing kernel interface to do this? still, it's not quite what i wanted, which is something that i can quickly, easily use to get stats over a quick interval, repeatedly during lots of little tests. our emphasis was on making that one thing easy. > if you don't want to zero your stats, i agree with others here, that a > simple script accomplishes the same thing without adding a lot of extra > baggage to the command. it's the unix way. yeah, i hear what you're saying, but i don't think it's "the unix way" to roll your own every time (scripts and whatnot, or having to say stuff in a tempfile and use --since over and over). it's a simple feature, it's not a lot of baggage. this discussion has gotten some feature-creep in it that maybe is obscuring the original intent. i think that zeroing all the counters is too much of a "big hammer" approach to what was intended to be a quick and simple use-case. if there's a kernel interface for zeroing stuff, then maybe that could be added, too; someone should have-at. thoughts, neil? for now, i'm just going to make patches to fix the false-positives-in-has_stats() bug, rename --diff-stat to --sleep, and update the manpage. if this feature still has any future at that point, i'll add neil's timeout and repeat flags. if someone else wants to have a different go at this, please, by all means, do. d . > -----Original Message----- > From: david m. richter [mailto:richterd@citi.umich.edu] > Sent: Wednesday, August 01, 2007 10:49 AM > To: Trond Myklebust > Cc: Peter Staubach; Neil Brown; Alex Soule; J. Bruce Fields; Andrew > Richardson; nfs@lists.sourceforge.net > Subject: Re: [NFS] [PATCH 0/7] nfsstat: adding -D/--diff-stat to nfsstat > > On Wed, 1 Aug 2007, Trond Myklebust wrote: > > > On Wed, 2007-08-01 at 13:35 -0400, david m. richter wrote: > > > > Can I make one more attempt to interest someone in implementing > > > > the --since=baseline-file approach? It'd be fun, and would make > > > > some more flexible use cases very simple. You could still get a > time interval: > > > > > > > > nfsstat >tmp > > > > sleep 30 > > > > nfsstat --since=tmp > > > > > > > > or you could do other stuff: > > > > > > > > nfsstat >tmp > > > > run-my-weird-test-case-here > > > > nfsstat --since=tmp > > > > Exactly. Being able to zero out the stats is way more flexible than > > the -D stuff... > > perhaps i don't follow: how is zeroing the stats address the > same use-case as --diff-stat/--sleep? one can already zero the stats by > unmounting, e.g., but that's a pain. ? i'm missing something. > > > > > just curious: would you be satisfied if the --since file's ctime > > > > were used as the beginning of the time interval? > > > > What time interval? nfsstat doesn't output any time intervals, and I > > can't see how these proposals introduce one. > > > > Is it perhaps Bruce's choice of the word '--since' that is confusing? > > right -- like i said in another letter, i was just being dumb. > :) > > > thanks, > > d > . > > ------------------------------------------------------------------------ > - > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > NFS maillist - NFS@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs