From: "J. Bruce Fields" Subject: Re: [PATCH 2/3] Remove old logging implementation for idmapd and rework gssd and idmapd to use the new xlog logging infrastructure. Date: Tue, 11 Sep 2007 13:16:21 -0400 Message-ID: <20070911171621.GI13948@fieldses.org> References: <1189459543.7914.16.camel@moss-terrapins.epoch.ncsc.mil> <1189515746.12340.4.camel@moss-terrapins.epoch.ncsc.mil> <4d569c330709110800g558b1fect5f84ea20e25efc7b@mail.gmail.com> <1189523208.12340.10.camel@moss-terrapins.epoch.ncsc.mil> <4d569c330709110824t60745764l3fc63a393d51b0b9@mail.gmail.com> <4d569c330709110828qfaf7726we21d80d8001c92f9@mail.gmail.com> <20070911153742.GG13948@fieldses.org> <1189530078.12340.28.camel@moss-terrapins.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: nfs@lists.sourceforge.net, nfsv4@linux-nfs.org To: "David P. Quigley" Return-path: In-Reply-To: <1189530078.12340.28.camel@moss-terrapins.epoch.ncsc.mil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-ID: On Tue, Sep 11, 2007 at 01:01:18PM -0400, David P. Quigley wrote: > Another question about the code in general. Why is it that idmapd is > using fcntl and user signals to indicate changes to the rpc pipe. Isn't > there something else we can use like Inotify or a Netlink socket? When a new nfs client is created, a new directory containing several files (including the upcall pipe) are created. The dnotify stuff is there so we find out about those new files and directories. I don't know much about netlink--how would it help us there? I assume Inotify would work, but I don't see any advantage over dnotify. If we didn't leave in some compatability code then it would mean dropping support for pre-inotify kernels, wouldn't it?--could be that there were only a few of those and that nfsv4 wasn't really usable on them anyway (I don't remember), but absent a real motivation to move from dnotify to inotify I'd rather not. > I am assuming that this is just a result of the code being written > before these things were in place. I was originally starting doimapd > based on the idmapd source however if it is acceptable to move to one > of these other techniques I can switched over to that instead. For new stuff I don't think there'd be a problem using something else. --b.