From: "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [RFC,
	PATCH 1/4] svc: Fix skip computation in svc_defer and	svc_revisit
Date: Tue, 23 Oct 2007 14:03:55 -0400
Message-ID: <20071023180354.GE30496@fieldses.org>
References: <20071019214058.31422.35615.stgit@dell3.ogc.int>
	<20071019214523.31422.28978.stgit@dell3.ogc.int>
	<20071023024530.GB6354@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: neilb@suse.de, nfs@lists.sourceforge.net
To: Greg Banks <gnb@sgi.com>
In-Reply-To: <20071023024530.GB6354@sgi.com>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Tue, Oct 23, 2007 at 12:45:30PM +1000, Greg Banks wrote:
> On Fri, Oct 19, 2007 at 04:45:23PM -0500, Tom Tucker wrote:
> > 
> > The rq_arg.len includes the size of the transport header. The computations
> > assumed that it did not.
> 
> ok, assuming that your latest svc_rdma_xdr_decode_req(), which I
> haven't read yet, doesn't change rq_arg.len as it parses the RDMA
> chunking header.
> 
> The reason I mention that is that one set of patches I was working
> with some time ago had different semantics for rq_arg.len; when
> parsing the chunking header, rq_arg.len was adjusted downward as
> rq_head[0].iov_base was adjusted forward.  This kept rq_arg.len equal
> to the sum of rq_{head[0],pages[...],tail[0]}.iov_len, which seemed
> like a good idea.
> 
> But your way seems valid too.

The integrity and privacy code may be a particularly unpleasant source
of assumptions about the various length fields; see e.g.
unwrap_integ_data() and unwrap_priv_data().  (But maybe nobody cares
about krb5i/krb5p over rdma?)

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs