From: Trond Myklebust Subject: Re: nfsv2 ref leak in 2.6.24? Date: Sun, 21 Oct 2007 12:58:12 -0400 Message-ID: <1192985892.7505.32.camel@heimdal.trondhjem.org> References: <200710202135.l9KLZJIB023526@agora.fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: bfields@fieldses.org, neilb@suse.de, nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org To: Erez Zadok Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1Ije7c-0002Wq-VT for nfs@lists.sourceforge.net; Sun, 21 Oct 2007 09:57:53 -0700 Received: from pat.uio.no ([129.240.10.15]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Ije7i-0006FF-1h for nfs@lists.sourceforge.net; Sun, 21 Oct 2007 09:57:58 -0700 In-Reply-To: <200710202135.l9KLZJIB023526@agora.fsl.cs.sunysb.edu> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Sat, 2007-10-20 at 17:35 -0400, Erez Zadok wrote: > Trond, I verified that w/ the above patch the problem is w/ nfs: the client > leaves .nfsXXX files behind for every file unlinked while open. Let me know > when you get a fix and I'll test it. Doh... Another typo. Trond -------------------------- CUT HERE -------------------- From: Trond Myklebust Date: Sun, 21 Oct 2007 12:02:22 -0400 NFS: Fix a typo in nfs_call_unlink() Signed-off-by: Trond Myklebust --- fs/nfs/unlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c index ce558c2..233ad38 100644 --- a/fs/nfs/unlink.c +++ b/fs/nfs/unlink.c @@ -171,7 +171,7 @@ static int nfs_call_unlink(struct dentry *dentry, struct nfs_unlinkdata *data) if (parent == NULL) goto out_free; dir = parent->d_inode; - if (nfs_copy_dname(dentry, data) == 0) + if (nfs_copy_dname(dentry, data) != 0) goto out_dput; /* Non-exclusive lock protects against concurrent lookup() calls */ spin_lock(&dir->i_lock); ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs