From: "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [RFC,
	PATCH 3/3] knfsd: Modify write_ports to use svc_find_xprt	service
Date: Wed, 10 Oct 2007 23:46:08 -0400
Message-ID: <20071011034608.GC6684@fieldses.org>
References: <20071011022356.3501.63859.stgit@dell3.ogc.int>
	<20071011022901.3501.5244.stgit@dell3.ogc.int>
	<18189.37354.527748.91357@notabene.brown>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: nfs@lists.sourceforge.net, gnb@sgi.com
To: Neil Brown <neilb@suse.de>
In-Reply-To: <18189.37354.527748.91357@notabene.brown>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Thu, Oct 11, 2007 at 01:00:58PM +1000, Neil Brown wrote:
> On Wednesday October 10, tom@opengridcomputing.com wrote:
> >  		if (sscanf(buf, "%15s %4d", transport, &port) == 2) {
> 
> We should give a bit of thought to this parsing and future expansion.
> Suppose we did want to pump more information into the kernel as has
> been suggested (e.g. local IP address), we would want this code to
> handle the new format correctly, probably by failing.
> 
> So maybe we really want
> 
> >  		if (sscanf(buf, "%15s %4d%c", transport, &port, &nl) == 2
> 	            && nl == '\n') {
> 
> or something like that???
> 
> BTW, I'm fairly happy with the state of this patch set and suggest
> that we aim for 2.6.24-rc1.  I still want to read through the final
> code with all patches applied, but I should be able to find time for
> that in the next month or so.  I don't expect any significant issues.

It seems OK to me, and it would be nice to get this batch in and have
just the rdma stuff left to merge in 2.6.25.

But we're very short for time, and it appears that there's still some
work to be done.  Certainly any user interfaces need to be sorted out,
as we'll be stuck with them....

Other work to be done: these incremental fixes are helpful for reviewers
like Greg who are keeping close watch on the process, but we need to
submit a patch series that shows our changes with perfect hindsight, so
we need to combine these with the previous patches.  I did this with the
most recent two of Tom's 7-patch series; result here:

	git://linux-nfs.org/~bfields/linux.git server-xprt-switch

I didn't apply patch #6 since Greg still had comments, and I haven't
applied the most recent fixes.

If this isn't all ready by Friday (OK, maybe Monday) then I think we're
out of time.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs