From: "J. Bruce Fields" Subject: Re: [RFC, PATCH 13/35] svc: Change services to use new svc_create_xprt service Date: Tue, 9 Oct 2007 13:09:23 -0400 Message-ID: <20071009170923.GH22750@fieldses.org> References: <20071001191426.3250.15371.stgit@dell3.ogc.int> <20071001192758.3250.2651.stgit@dell3.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: neilb@suse.de, nfs@lists.sourceforge.net, aglo@citi.umich.edu, gnb@sgi.com To: Tom Tucker Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1IfIaE-0000E6-Se for nfs@lists.sourceforge.net; Tue, 09 Oct 2007 10:09:29 -0700 Received: from mail.fieldses.org ([66.93.2.214] helo=fieldses.org) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IfIaI-0000w1-RD for nfs@lists.sourceforge.net; Tue, 09 Oct 2007 10:09:32 -0700 In-Reply-To: <20071001192758.3250.2651.stgit@dell3.ogc.int> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Mon, Oct 01, 2007 at 02:27:59PM -0500, Tom Tucker wrote: > diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c > index a796be5..e27ca14 100644 > --- a/fs/nfs/callback.c > +++ b/fs/nfs/callback.c > @@ -123,8 +123,8 @@ int nfs_callback_up(void) > if (!serv) > goto out_err; > > - ret = svc_makesock(serv, IPPROTO_TCP, nfs_callback_set_tcpport, > - SVC_SOCK_ANONYMOUS); > + ret = svc_create_xprt(serv, "tcp", nfs_callback_set_tcpport, > + SVC_SOCK_ANONYMOUS); > if (ret <= 0) > goto out_destroy; > nfs_callback_tcpport = ret; Looks like svc_makesock returned a port number, where svc_create_xprt returns a 0 or -ERRNO. This is breaking nfsv4 callbacks. --b. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs