From: Tom Tucker <tom@opengridcomputing.com>
Subject: Re: [RFC,
	PATCH 04/35] svc: Add a max payload value to the transport
Date: Wed, 03 Oct 2007 09:26:53 -0500
Message-ID: <1191421613.1565.100.camel@trinity.ogc.int>
References: <20071001191426.3250.15371.stgit@dell3.ogc.int>
	<20071001192738.3250.6971.stgit@dell3.ogc.int>
	<8E01CAF1-5D8D-4AE5-B15D-C04983079F76@oracle.com>
	<1191342488.1565.8.camel@trinity.ogc.int>
	<20071003110932.GN21388@sgi.com>
Reply-To: tom@opengridcomputing.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: neilb@suse.de, bfields@fieldses.org, nfs@lists.sourceforge.net
To: Greg Banks <gnb@sgi.com>
In-Reply-To: <20071003110932.GN21388@sgi.com>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Wed, 2007-10-03 at 21:09 +1000, Greg Banks wrote:
> On Tue, Oct 02, 2007 at 11:28:08AM -0500, Tom Tucker wrote:

[...snip...]

> > 
> > The premise was that I didn't want a given thread peeking into some
> > other processors memory, so anything needed from the class is copied
> > into the svc_xprt structure when the transport instance is created.
> 
> If I understand the code correctly, the only field in svc_xprt_class
> that ever changes is the list_head used to add it to the global list,
> which changes once when the transport module is loaded.  After that
> all the svc_xprt_class cachelines will remain in shared state in all
> CPUs' caches; it's effectively read-only.  Given that, there's little
> to be concerned about.
> 
> > 
> > Greg, help me here ;-)
> 
> Sorry, I agree with Chuck :-/

np, let's get it right. So the max_payload should remain in the
svc_xprt_class structure. 

I see only one possible benefit of copying the svc_xprt_ops structure
and that is that it saves one ptr de-reference when calling ops. What's
the consensus? Copy it, or keep a ptr?

Tom

> 
> Greg.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs