From: "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [RFC,PATCH 14/35] svc: Change sk_inuse to a kref
Date: Wed, 3 Oct 2007 11:34:01 -0400
Message-ID: <20071003153401.GD10001@fieldses.org>
References: <20071001191426.3250.15371.stgit@dell3.ogc.int>
	<20071001192801.3250.49751.stgit@dell3.ogc.int>
	<20071003111210.GA19381@infradead.org>
	<20071003144517.GA10001@fieldses.org>
	<20071003145238.GA30564@infradead.org>
	<50751C78-DD55-4549-A03E-2DFBBEF7AED3@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: Christoph Hellwig <hch@infradead.org>, neilb@suse.de,
	nfs@lists.sourceforge.net, gnb@sgi.com
To: Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <50751C78-DD55-4549-A03E-2DFBBEF7AED3@oracle.com>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Wed, Oct 03, 2007 at 11:13:58AM -0400, Chuck Lever wrote:
> We're using krefs without issue in several other areas of the RPC client 
> and server.  Both rpc_clnt and rpc_xprt have a kref in them, for example.  
> I don't see the harm in using them here as well, as long as they are used 
> carefully.

I believe the change in this case is more or less a no-op, so I can't
bring myself to care either way.

I seem to recall Andrew (? I thought?) saying that the use of kref's
helped made obvious cases where use of a reference count followed the
simplest

	atomic_set( ,0) on init
	atomic_inc() on get
	atomic_dec_and_test() on put

pattern, and that that simplified reviewing.

I dunno.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs