From: Greg Banks <gnb@sgi.com>
Subject: Re: [RFC,
	PATCH 12/35] svc: Add a generic transport svc_create_xprt function
Date: Thu, 4 Oct 2007 12:30:24 +1000
Message-ID: <20071004023024.GU21388@sgi.com>
References: <20071001191426.3250.15371.stgit@dell3.ogc.int>
	<20071001192756.3250.60536.stgit@dell3.ogc.int>
	<383DDDA6-29E5-41CF-A2F7-9C45BB26CE64@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: neilb@suse.de, bfields@fieldses.org, nfs@lists.sourceforge.net
To: Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <383DDDA6-29E5-41CF-A2F7-9C45BB26CE64@oracle.com>
Sender: nfs-bounces@lists.sourceforge.net
Errors-To: nfs-bounces@lists.sourceforge.net

On Tue, Oct 02, 2007 at 11:39:18AM -0400, Chuck Lever wrote:
> On Oct 1, 2007, at 3:27 PM, Tom Tucker wrote:
> >
> > struct svc_xprt_ops {
> >+	struct svc_xprt	*(*xpo_create)(struct svc_serv *,
> >+				       struct sockaddr *,
> >+				       int);
> 
> Should xpo_create also have a length argument, as in (struct sockaddr  
> *, socklen_t) ?

Consistency would be nice.  Let's see, how often do we
maintain address length fields now?

svc_deferred_req.addr: yes
svc_rqst.rq_addr: yes
svc_sock.sk_local: no
svc_sock.sk_remote: yes
rpc_xprt.addr: yes
rpc_create_args.address:     \
rpc_create_args.saddress:    / one length field for both
rpc_xprtsock_create.srcaddr: \
rpc_xprtsock_create.dstaddr: / one length field for both
rpc_peeraddr(): yes
rpcb_create(): no
xs_send_kvec(): yes
xs_sendpages(): yes
__svc_print_addr(): no
svc_port_is_privileged(): no
svc_create_socket(): yes

> (or whatever the type of sockaddr lengths are: size_t perhaps?)

socklen_t should be right, but the kernel doesn't seem to have one.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs