From: cpebenito@tresys.com (Christopher J. PeBenito)
Date: Thu, 09 Sep 2010 08:11:34 -0400
Subject: [refpolicy] [Acct 1/1] Clean up acct module.
In-Reply-To: <20100903154559.GA27629@localhost.localdomain>
References: <20100903154559.GA27629@localhost.localdomain>
Message-ID: <4C88CEF6.2090908@tresys.com>
To: refpolicy@oss.tresys.com
List-Id: refpolicy.oss.tresys.com
On 09/03/10 11:46, Dominick Grift wrote:
> --- a/policy/modules/admin/acct.if
> +++ b/policy/modules/admin/acct.if
> @@ -1,8 +1,9 @@
> -##Berkeley process accounting
> +##Berkeley process accounting.
>
> ########################################
> ##
> -## Transition to the accounting management domain.
> +## Execute a domain transition to run
> +## accounting management tools.
> ##
> ##
> ##
> @@ -21,7 +22,7 @@ interface(`acct_domtrans',`
>
> ########################################
> ##
> -## Execute accounting management tools in the caller domain.
> +## Execute accounting management tools.
> ##
> ##
> ##
> @@ -40,7 +41,7 @@ interface(`acct_exec',`
>
> ########################################
> ##
> -## Execute accounting management data in the caller domain.
> +## Execute accounting management data.
> ##
> ##
> ##
> @@ -61,7 +62,7 @@ interface(`acct_exec_data',`
>
> ########################################
> ##
> -## Create, read, write, and delete process accounting data.
> +## Manage accounting data.
> ##
> ##
> ##
This one makes it worse, in my opinion. I prefer to keep the "create,
read, write, and delete" so that people that aren't as familiar with
what we mean by "manage" have an idea of what it means by the docs.
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com