From: cpebenito@tresys.com (Christopher J. PeBenito)
Date: Mon, 12 Mar 2012 09:11:35 -0400
Subject: [refpolicy] [PATCH v2 1/1] Support LDAP backend infrastructure
In-Reply-To: <4F5DF5A5.7000104@tresys.com>
References: <20120301200255.GA17815@siphos.be> <4F5619E3.8040106@tresys.com>
	<20120306201022.GA6788@siphos.be>
	<20120306205423.GA7987@siphos.be> <4F5DF5A5.7000104@tresys.com>
Message-ID: <4F5DF607.404@tresys.com>
To: refpolicy@oss.tresys.com
List-Id: refpolicy.oss.tresys.com

On 03/12/12 09:09, Christopher J. PeBenito wrote:
> On 03/06/12 15:54, Sven Vermeulen wrote:
>> On Tue, Mar 06, 2012 at 09:10:22PM +0100, Sven Vermeulen wrote:
>>>>> @@ -68,6 +74,7 @@ corenet_tcp_bind_generic_node(dhcpd_t)
>>>>>  corenet_udp_bind_generic_node(dhcpd_t)
>>>>>  corenet_tcp_bind_dhcpd_port(dhcpd_t)
>>>>>  corenet_udp_bind_dhcpd_port(dhcpd_t)
>>>>> +corenet_udp_bind_generic_port(dhcpd_t)
>>>>
>>>> Looks like a port needs to be defined.
>>>
>>> Not really, but the call should be corenet_udp_bind_all_unreserved_ports,
>>> not corenet_udp_bind_generic_port. Guess I'll have to go for personal
>>> testing more than to accept an "it works" on a bugreport :p
> 
> Sounds like the above is the change we need.  Please also add a comment that describes what you found below, so we can remember it next time this comes up.

To clarify: a comment in the policy, not just in the commit message.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com