From: dominick.grift@gmail.com (Dominick Grift) Date: Thu, 13 Sep 2012 18:06:14 +0200 Subject: [refpolicy] [PATCH] Add Debian location for rtkit-daemon daemon In-Reply-To: <50520213.40902@redhat.com> References: <1347488050-19736-1-git-send-email-bigon@debian.org> <1347538790.2915.20.camel@d30.localdomain> <50520213.40902@redhat.com> Message-ID: <1347552374.2915.27.camel@d30.localdomain> To: refpolicy@oss.tresys.com List-Id: refpolicy.oss.tresys.com On Thu, 2012-09-13 at 11:56 -0400, Daniel J Walsh wrote: > On 09/13/2012 08:19 AM, Dominick Grift wrote: > > > > > > On Thu, 2012-09-13 at 00:14 +0200, Laurent Bigonville wrote: > >> From: Laurent Bigonville > >> > >> --- rtkit.fc | 4 ++++ 1 file changed, 4 insertions(+) > >> > >> diff --git a/rtkit.fc b/rtkit.fc index 52c441e..fd82305 100644 --- > >> a/rtkit.fc +++ b/rtkit.fc @@ -1 +1,5 @@ /usr/libexec/rtkit-daemon -- > >> gen_context(system_u:object_r:rtkit_daemon_exec_t,s0) + > >> +ifdef(`distro_debian',` +/usr/lib/rtkit/rtkit-daemon -- > >> gen_context(system_u:object_r:rtkit_daemon_exec_t,s0) +') > > > > This was merged. Thanks > > > > _______________________________________________ refpolicy mailing list > > refpolicy at oss.tresys.com http://oss.tresys.com/mailman/listinfo/refpolicy > > > I have never been a big fan of the ifdef(DISTRO) stuff in the fc files. Why is > it necessary hear? Only reason for this would be if another distro had a file > here named /usr/lib/rtkit/rtkit-daemon that they wanted to label differently. > Lets not flood the fc files with these macros. I could definitely see Fedora > moving to this location. Driven by systemd. I agree, but until we get consensus cross the board regarding this issue i don't see any reason to reject these patches. removing the ifdef wrappers is trivial so as soon as we can all agree ill remove them. So i would like to hear opinions of at least pebenito. bigon and swift about this as well (which i cc'd)