From: cpebenito@tresys.com (Christopher J. PeBenito) Date: Tue, 2 Dec 2014 10:31:38 -0500 Subject: [refpolicy] Syntax fixes in contrib In-Reply-To: <1416983956-8770-1-git-send-email-jason@perfinion.com> References: <1416983956-8770-1-git-send-email-jason@perfinion.com> Message-ID: <547DDB5A.3000307@tresys.com> To: refpolicy@oss.tresys.com List-Id: refpolicy.oss.tresys.com On 11/26/2014 1:38 AM, Jason Zaman wrote: > I was going through the policy and adding all the _admin interfaces to sysadm > in the gentoo policy and hit quite a number of syntax errors. They are mostly > just typos and missing types in gen_require. > > The last two remove the _role interface to not be called from _admin since the > the _role is already called from in the role definitions and there is a > conflict if it gets called twice so removing it from the _admin interface > seemed reasonable. Commented them out and wrote a note above. Would it instead > be preferred if i just removed it completely? At first I wanted it removed, but then decided it's fine to keep the comments, so we don't add it back in at some point in the future. Or maybe it will work in the future, so we can add it back. This set is merged. -- Chris PeBenito Tresys Technology, LLC www.tresys.com | oss.tresys.com