From: cpebenito@tresys.com (Christopher J. PeBenito)
Date: Wed, 27 May 2015 13:04:37 -0400
Subject: [refpolicy] [PATCH] Add openrc support to init_startstop_service
In-Reply-To: <20150527165132.GA14860@x131e>
References: <1432548165-19277-1-git-send-email-jason@perfinion.com>	<5565F552.2070007@tresys.com>
	<20150527165132.GA14860@x131e>
Message-ID: <5565F925.9070402@tresys.com>
To: refpolicy@oss.tresys.com
List-Id: refpolicy.oss.tresys.com

On 5/27/2015 12:51 PM, Dominick Grift wrote:
> On Wed, May 27, 2015 at 12:48:18PM -0400, Christopher J. PeBenito wrote:
>> On 5/25/2015 6:02 AM, Jason Zaman wrote:
>>> Adds the openrc rules in ifdef distro_gentoo to transition
>>> to run_init correctly.
>>
>> I'm fine with this set except one note below.
>>
> 
> <snip>
> 
>>
>> "spec" means setexeccon(), instead of type_transition, so this should
>> drop the "spec" from the name.  Same thing in the caller below.
>>
> 
> Just a quick comment from an innocent bystander:
> 
> I appreciate that it is what it is, but i don't find it intuitive and in my personal policy i use "automatic versus manual" transition

It's so infrequently used that I haven't thought about it much.  I'm
open to considering naming changes as long as it doesn't require
changing a ton of interfaces.  i.e. "domtrans" by itself would have to
continue to mean domain transition via type_transition.  There's not
even an official naming convention for dyntransition interfaces since
none exist (that is, none that only do dyntransition).

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com