From: guido@trentalancia.net (Guido Trentalancia)
Date: Wed, 28 Dec 2016 20:05:59 +0100
Subject: [refpolicy] [PATCH v3 2/2] contrib: support the new interface
	to manage X session logs
In-Reply-To: <443b8c08-7dd5-31e1-1474-f1266fb5d548@ieee.org>
References: <1482247723.12013.1.camel@trentalancia.net>
	<1482247816.12013.3.camel@trentalancia.net>
	<1482361519.9387.3.camel@trentalancia.net>
	<1482419754.3408.1.camel@trentalancia.net>
	<443b8c08-7dd5-31e1-1474-f1266fb5d548@ieee.org>
Message-ID: <CE20AC2B-F404-407A-B0E5-0CF8E6124374@trentalancia.net>
To: refpolicy@oss.tresys.com
List-Id: refpolicy.oss.tresys.com

Hello. 

There isn't a specific reason for not explicitly creating the dependance of xscreensaver from xserver, so it can surely be improved that way. 

Regards, 

Guido 

Il 28 dicembre 2016 19:26:00 CET, Chris PeBenito <pebenito@ieee.org> ha scritto:
>On 12/22/16 10:15, Guido Trentalancia via refpolicy wrote:
>> diff -pru a/policy/modules/contrib/xscreensaver.te
>b/policy/modules/contrib/xscreensaver.te
>> --- a/policy/modules/contrib/xscreensaver.te	2016-12-22
>16:03:10.938097722 +0100
>> +++ b/policy/modules/contrib/xscreensaver.te	2016-12-22
>16:03:21.182221508 +0100
>> @@ -58,7 +58,10 @@ miscfiles_read_localization(xscreensaver
>>  userdom_use_user_terminals(xscreensaver_t)
>>  userdom_read_user_home_content_files(xscreensaver_t)
>>
>> -xserver_user_x_domain_template(xscreensaver, xscreensaver_t,
>xscreensaver_tmpfs_t)
>> +optional_policy(`
>> +	xserver_rw_xsession_log(xscreensaver_t)
>> +	xserver_user_x_domain_template(xscreensaver, xscreensaver_t,
>xscreensaver_tmpfs_t)
>> +')
>>
>>  ########################################
>>  #
>
>I didn't notice this before, but why would xserver be optional for 
>xscreensaver?