From: jwcart2@tycho.nsa.gov (James Carter) Date: Wed, 11 Apr 2018 14:56:38 -0400 Subject: [refpolicy] [PATCH 08/13] Remove undeclared identifiers from shorewall interfaces In-Reply-To: <20180411185639.23547-1-jwcart2@tycho.nsa.gov> References: <20180411185639.23547-1-jwcart2@tycho.nsa.gov> Message-ID: <20180411185639.23547-9-jwcart2@tycho.nsa.gov> To: refpolicy@oss.tresys.com List-Id: refpolicy.oss.tresys.com Both shorewall_read_pid_files() and shorewall_rw_pid_files() use the undeclared type shorewall_var_run_t. Removed statements referring to this type and marked the interfaces as deprecated because they no longer do anything useful. Neither interface is called in the policy. Signed-off-by: James Carter --- shorewall.if | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/shorewall.if b/shorewall.if index 108ce75..119ba27 100644 --- a/shorewall.if +++ b/shorewall.if @@ -62,38 +62,28 @@ interface(`shorewall_read_config',` ## ## Read shorewall pid files. ## -## +## ## ## Domain allowed access. ## ## # interface(`shorewall_read_pid_files',` - gen_require(` - type shorewall_var_run_t; - ') - - files_search_pids($1) - read_files_pattern($1, shorewall_var_run_t, shorewall_var_run_t) + refpolicywarn(`$0($*) has been deprecated') ') ####################################### ## ## Read and write shorewall pid files. ## -## +## ## ## Domain allowed access. ## ## # interface(`shorewall_rw_pid_files',` - gen_require(` - type shorewall_var_run_t; - ') - - files_search_pids($1) - rw_files_pattern($1, shorewall_var_run_t, shorewall_var_run_t) + refpolicywarn(`$0($*) has been deprecated') ') ###################################### -- 2.13.6