2009-07-08 16:11:32

by Jaswinder Singh Rajput

Subject: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

fix the following 'make includecheck' warning:

include/linux/rfkill.h: linux/types.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/rfkill.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index e73e242..2ce2983 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -99,7 +99,6 @@ enum rfkill_user_states {
#undef RFKILL_STATE_UNBLOCKED
#undef RFKILL_STATE_HARD_BLOCKED

-#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/mutex.h>
--
1.6.0.6

2009-07-08 19:32:36

by Marcel Holtmann

Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

> fix the following 'make includecheck' warning:
>
> include/linux/rfkill.h: linux/types.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---
> include/linux/rfkill.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index e73e242..2ce2983 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -99,7 +99,6 @@ enum rfkill_user_states {
> #undef RFKILL_STATE_UNBLOCKED
> #undef RFKILL_STATE_HARD_BLOCKED
>
> -#include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/list.h>
> #include <linux/mutex.h>

with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
correct.

Regards

Marcel

2009-07-09 04:03:47

by Jaswinder Singh Rajput

Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hello Marcel,

On Wed, 2009-07-08 at 12:32 -0700, Marcel Holtmann wrote:
> Hi Jaswinder,
>
> > fix the following 'make includecheck' warning:
> >
> > include/linux/rfkill.h: linux/types.h is included more than once.
> >
> > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> > ---
> > include/linux/rfkill.h | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index e73e242..2ce2983 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> > #undef RFKILL_STATE_UNBLOCKED
> > #undef RFKILL_STATE_HARD_BLOCKED
> >
> > -#include <linux/types.h>
> > #include <linux/kernel.h>
> > #include <linux/list.h>
> > #include <linux/mutex.h>
>
> with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> correct.
>

ACK or Reviewed-by ?

Thanks,
--
JSR

2009-07-09 05:47:39

by Marcel Holtmann

Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

> > > fix the following 'make includecheck' warning:
> > >
> > > include/linux/rfkill.h: linux/types.h is included more than once.
> > >
> > > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> > > ---
> > > include/linux/rfkill.h | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > > index e73e242..2ce2983 100644
> > > --- a/include/linux/rfkill.h
> > > +++ b/include/linux/rfkill.h
> > > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> > > #undef RFKILL_STATE_UNBLOCKED
> > > #undef RFKILL_STATE_HARD_BLOCKED
> > >
> > > -#include <linux/types.h>
> > > #include <linux/kernel.h>
> > > #include <linux/list.h>
> > > #include <linux/mutex.h>
> >
> > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> > correct.
> >
>
> ACK or Reviewed-by ?

both if you want to, but John already picked it up for wireless-testing
if I am not mistaken. So it is on its way into 2.6.32 somehow.

Regards

Marcel