2010-02-04 21:53:31

by Benoit Papillault

Subject: [PATCH] mac80211: Fix probe request filtering in IBSS mode

We only reply to probe request if either the requested SSID is the
broadcast SSID or if the requested SSID matches our own SSID. This
latter case was not properly handled since we were replying to different
SSID with the same length as our own SSID.

Signed-off-by: Benoit Papillault <[email protected]>
---
net/mac80211/ibss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index 86bd2a0..e905c45 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -714,7 +714,7 @@ static void ieee80211_rx_mgmt_probe_req(struct ieee80211_sub_if_data *sdata,
}
if (pos[1] != 0 &&
(pos[1] != ifibss->ssid_len ||
- !memcmp(pos + 2, ifibss->ssid, ifibss->ssid_len))) {
+ memcmp(pos + 2, ifibss->ssid, ifibss->ssid_len))) {
/* Ignore ProbeReq for foreign SSID */
return;
}
--
1.6.3.3

2010-02-04 23:55:01

by Luis R. Rodriguez

Subject: Re: [PATCH] mac80211: Fix probe request filtering in IBSS mode

On Thu, Feb 4, 2010 at 1:34 PM, Benoit Papillault
<[email protected]> wrote:
> We only reply to probe request if either the requested SSID is the
> broadcast SSID or if the requested SSID matches our own SSID. This
> latter case was not properly handled since we were replying to different
> SSID with the same length as our own SSID.
>
> Signed-off-by: Benoit Papillault <[email protected]>

Cc: [email protected] it seems?

Luis

2010-02-05 00:12:04

by Benoit Papillault

Subject: Re: [PATCH] mac80211: Fix probe request filtering in IBSS mode

Luis R. Rodriguez a écrit :
> On Thu, Feb 4, 2010 at 1:34 PM, Benoit Papillault
> <[email protected]> wrote:
>
>> We only reply to probe request if either the requested SSID is the
>> broadcast SSID or if the requested SSID matches our own SSID. This
>> latter case was not properly handled since we were replying to different
>> SSID with the same length as our own SSID.
>>
>> Signed-off-by: Benoit Papillault <[email protected]>
>>
>
> Cc: [email protected] it seems?
>
> Luis
>
Indeed! Do I need to resend?
Benoit

2010-02-05 00:13:25

by Luis R. Rodriguez

Subject: Re: [PATCH] mac80211: Fix probe request filtering in IBSS mode

On Thu, Feb 4, 2010 at 4:11 PM, Benoit PAPILLAULT
<[email protected]> wrote:
> Luis R. Rodriguez a écrit :
>>
>> On Thu, Feb 4, 2010 at 1:34 PM, Benoit Papillault
>> <[email protected]> wrote:
>>
>>>
>>> We only reply to probe request if either the requested SSID is the
>>> broadcast SSID or if the requested SSID matches our own SSID. This
>>> latter case was not properly handled since we were replying to different
>>> SSID with the same length as our own SSID.
>>>
>>> Signed-off-by: Benoit Papillault <[email protected]>
>>>
>>
>> Cc: [email protected] it seems?
>>
>>  Luis
>>
>
> Indeed! Do I need to resend?

Its easy to resend so just go ahead.

Luis