2010-09-30 22:21:11

by Bill Jordan

Subject: [PATCH 2/3] cfg80211: patches to allow setting the WDS peer

Added a nl interface to set the peer bssid of a WDS interface.

Signed-off-by: Bill Jordan <[email protected]>
---
include/linux/nl80211.h | 3 ++
net/wireless/nl80211.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 0 deletions(-)

diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
index f0518b0..35a9681 100644
--- a/include/linux/nl80211.h
+++ b/include/linux/nl80211.h
@@ -387,6 +387,8 @@
* of any other interfaces, and other interfaces will again take
* precedence when they are used.
*
+ * @NL80211_CMD_SET_WDS_PEER: Set the MAC address of the peer on a
WDS interface.
+ *
* @NL80211_CMD_MAX: highest used command number
* @__NL80211_CMD_AFTER_LAST: internal use
*/
@@ -489,6 +491,7 @@ enum nl80211_commands {
NL80211_CMD_NOTIFY_CQM,

NL80211_CMD_SET_CHANNEL,
+ NL80211_CMD_SET_WDS_PEER,

/* add new commands above here */

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 9c84825..c401349 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -603,6 +603,7 @@ static int nl80211_send_wiphy(struct sk_buff *msg,
u32 pid, u32 seq, int flags,
NLA_PUT_U32(msg, i, NL80211_CMD_SET_WIPHY_NETNS);
}
CMD(set_channel, SET_CHANNEL);
+ CMD(set_wds_peer, SET_WDS_PEER);

#undef CMD

@@ -831,6 +832,48 @@ static int nl80211_set_channel(struct sk_buff
*skb, struct genl_info *info)
return result;
}

2010-09-30 22:28:42

by Johannes Berg

Subject: Re: [PATCH 2/3] cfg80211: patches to allow setting the WDS peer

On Thu, 2010-09-30 at 18:21 -0400, Bill Jordan wrote:

> net/wireless/nl80211.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++

> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -603,6 +603,7 @@ static int nl80211_send_wiphy(struct sk_buff *msg,
> u32 pid, u32 seq, int flags,
> NLA_PUT_U32(msg, i, NL80211_CMD_SET_WIPHY_NETNS);
> }
> CMD(set_channel, SET_CHANNEL);
> + CMD(set_wds_peer, SET_WDS_PEER);
>
> #undef CMD
>
> @@ -831,6 +832,48 @@ static int nl80211_set_channel(struct sk_buff
> *skb, struct genl_info *info)
> return result;
> }
>

This patch was somehow cut short.

Also, your patches are line-wrapped, which means they cannot be applied.

You can find information on fixing that in
Documentation/email-clients.txt, but gmail web interface simply cannot
work.

Finally, it'd be nice if you could thread your patches into the thread
opened by the 0/N patch. Maybe look at quilt?

johannes

2010-10-01 00:25:28

by Luis R. Rodriguez

Subject: Re: [PATCH 2/3] cfg80211: patches to allow setting the WDS peer

On Thu, Sep 30, 2010 at 03:29:15PM -0700, Johannes Berg wrote:
> On Thu, 2010-09-30 at 18:21 -0400, Bill Jordan wrote:
>
> > net/wireless/nl80211.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++
>
> > --- a/net/wireless/nl80211.c
> > +++ b/net/wireless/nl80211.c
> > @@ -603,6 +603,7 @@ static int nl80211_send_wiphy(struct sk_buff *msg,
> > u32 pid, u32 seq, int flags,
> > NLA_PUT_U32(msg, i, NL80211_CMD_SET_WIPHY_NETNS);
> > }
> > CMD(set_channel, SET_CHANNEL);
> > + CMD(set_wds_peer, SET_WDS_PEER);
> >
> > #undef CMD
> >
> > @@ -831,6 +832,48 @@ static int nl80211_set_channel(struct sk_buff
> > *skb, struct genl_info *info)
> > return result;
> > }
> >
>
> This patch was somehow cut short.
>
> Also, your patches are line-wrapped, which means they cannot be applied.
>
> You can find information on fixing that in
> Documentation/email-clients.txt, but gmail web interface simply cannot
> work.

You can use git sende-mail as documented on that link I gave you, Bill.
>
> Finally, it'd be nice if you could thread your patches into the thread
> opened by the 0/N patch. Maybe look at quilt?

And this is accomplished with --no-chain-reply-to git send-email as
mentioned in the same guide.

Luis