2011-03-30 17:18:46

by Ohad Ben Cohen

[permalink] [raw]
Subject: [PATCH] wl12xx: fix "JOIN while associated" commentary

Issuing multiple JOIN commands to the wl12xx's firmware, while
we're associated, might have undesired implications, so the driver
prints a message when that happens, and warn developers who check
out the source.

Update the commentary in order to consider the one valid scenario
where this can happen: roaming.

Cautiously keep the message for now, until we either gain confidence
there are no unintentional JOIN-while-associated events, or until
we move to the new multi-role fw who solves this multiple-join issue
for good.

Signed-off-by: Ohad Ben-Cohen <[email protected]>
---
drivers/net/wireless/wl12xx/main.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 85cb4da..92def80 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -1569,10 +1569,10 @@ static int wl1271_join(struct wl1271 *wl, bool set_assoc)
* One of the side effects of the JOIN command is that is clears
* WPA/WPA2 keys from the chipset. Performing a JOIN while associated
* to a WPA/WPA2 access point will therefore kill the data-path.
- * Currently there is no supported scenario for JOIN during
- * association - if it becomes a supported scenario, the WPA/WPA2 keys
- * must be handled somehow.
- *
+ * Currently the only valid scenario for JOIN during association
+ * is on roaming, in which case we will also be given new keys.
+ * Keep the below message for now, unless it starts bothering
+ * users who really like to roam a lot :)
*/
if (test_bit(WL1271_FLAG_STA_ASSOCIATED, &wl->flags))
wl1271_info("JOIN while associated.");
--
1.7.1



2011-04-01 09:09:37

by Luciano Coelho

[permalink] [raw]
Subject: Re: [PATCH] wl12xx: fix "JOIN while associated" commentary

On Wed, 2011-03-30 at 19:18 +0200, Ohad Ben-Cohen wrote:
> Issuing multiple JOIN commands to the wl12xx's firmware, while
> we're associated, might have undesired implications, so the driver
> prints a message when that happens, and warn developers who check
> out the source.
>
> Update the commentary in order to consider the one valid scenario
> where this can happen: roaming.
>
> Cautiously keep the message for now, until we either gain confidence
> there are no unintentional JOIN-while-associated events, or until
> we move to the new multi-role fw who solves this multiple-join issue
> for good.
>
> Signed-off-by: Ohad Ben-Cohen <[email protected]>
> ---

Applied, thanks Ohad!

--
Cheers,
Luca.