On embedded hardware it's normal to not have a PCI device for the PCI
bridge that the wifi card is attached to. pdev->bus->self will be
NULL in that case. In that case, simply return without emitting an
useless kernel stack trace.
Signed-off-by: Felix Fietkau <[email protected]>
---
drivers/net/wireless/ath/ath9k/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c
index 5685cf1..d8f22aa 100644
--- a/drivers/net/wireless/ath/ath9k/pci.c
+++ b/drivers/net/wireless/ath/ath9k/pci.c
@@ -129,7 +129,7 @@ static void ath_pci_aspm_init(struct ath_common *common)
return;
parent = pdev->bus->self;
- if (WARN_ON(!parent))
+ if (!parent)
return;
pos = pci_pcie_cap(parent);
--
1.7.3.2
On 2011-08-15 12:51 PM, Stanislaw Gruszka wrote:
> On Sat, Aug 13, 2011 at 10:13:49AM -0600, Felix Fietkau wrote:
>> On embedded hardware it's normal to not have a PCI device for the PCI
>> bridge that the wifi card is attached to. pdev->bus->self will be
>> NULL in that case. In that case, simply return without emitting an
>> useless kernel stack trace.
>
> Patch is obviously ok, ACK. However I'm not sure if we should not
> do anything regarding ASPM. Perhaps there is other way to find out
> pcie parent ASPM settings on embedded systems?
I don't think the embedded system that I'm working on even uses ASPM.
- Felix
On Sat, Aug 13, 2011 at 10:13:49AM -0600, Felix Fietkau wrote:
> On embedded hardware it's normal to not have a PCI device for the PCI
> bridge that the wifi card is attached to. pdev->bus->self will be
> NULL in that case. In that case, simply return without emitting an
> useless kernel stack trace.
Patch is obviously ok, ACK. However I'm not sure if we should not
do anything regarding ASPM. Perhaps there is other way to find out
pcie parent ASPM settings on embedded systems?
Stanislaw