2013-01-27 18:55:30

by Guenter Roeck

Subject: [PATCH] net: iwlegacy: remove unused variable

Fix:

drivers/net/wireless/iwlegacy/4965.c: In function ‘il4965_post_associate’:
drivers/net/wireless/iwlegacy/4965.c:1751:25: warning: variable ‘conf’ set but
not used [-Wunused-but-set-variable]

seen when building allmodconfig on x86_64 with W=1 by removing the unused
variable.

Signed-off-by: Guenter Roeck <[email protected]>
---
drivers/net/wireless/iwlegacy/4965.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/iwlegacy/4965.c b/drivers/net/wireless/iwlegacy/4965.c
index 5db1171..91eb2d0 100644
--- a/drivers/net/wireless/iwlegacy/4965.c
+++ b/drivers/net/wireless/iwlegacy/4965.c
@@ -1748,7 +1748,6 @@ static void
il4965_post_associate(struct il_priv *il)
{
struct ieee80211_vif *vif = il->vif;
- struct ieee80211_conf *conf = NULL;
int ret = 0;

if (!vif || !il->is_open)
@@ -1759,8 +1758,6 @@ il4965_post_associate(struct il_priv *il)

il_scan_cancel_timeout(il, 200);

- conf = &il->hw->conf;
-
il->staging.filter_flags &= ~RXON_FILTER_ASSOC_MSK;
il_commit_rxon(il);

--
1.7.9.7

2013-01-28 09:56:52

by Stanislaw Gruszka

Subject: Re: [PATCH] net: iwlegacy: remove unused variable

On Sun, Jan 27, 2013 at 10:55:41AM -0800, Guenter Roeck wrote:
> drivers/net/wireless/iwlegacy/4965.c: In function ‘il4965_post_associate’:
> drivers/net/wireless/iwlegacy/4965.c:1751:25: warning: variable ‘conf’ set but
> not used [-Wunused-but-set-variable]
>
> seen when building allmodconfig on x86_64 with W=1 by removing the unused
> variable.
>
> Signed-off-by: Guenter Roeck <[email protected]>

ACK