2013-04-19 20:39:38

by Joerg Mayer

Subject: [PATCHv2] iw: Deocde some more IEs

Small update, found while verifying against the standard.

Thanks
Jörg

The results of a boring train ride:
- Decode some IEs sent by other traveller's devices
+ IBSS ATIM window
+ TPC report
+ Old ERP IE (802.11g D4.0)
- Tiny whitespace fix
- Add Unit 'TUs' to beacon interval.

v2: TPC: Link margin element is not used in beacons

In case this project requires a sob:
Signed-off-by: Joerg Mayer <[email protected]>

diff --git a/scan.c b/scan.c
index dfb78c0..0863ad0 100644
--- a/scan.c
+++ b/scan.c
@@ -285,6 +285,12 @@ static void print_powerconstraint(const uint8_t type, uint8_t len, const uint8_t
printf(" %d dB\n", data[0]);
}

+static void print_tpcreport(const uint8_t type, uint8_t len, const uint8_t *data)
+{
+ printf(" TX power: %d dBm\n", data[0]);
+ /* printf(" Link Margin (%d dB) is reserved in Beacons\n", data[1]); */
+}
+
static void print_erp(const uint8_t type, uint8_t len, const uint8_t *data)
{
if (data[0] == 0x00)
@@ -693,6 +699,11 @@ static void print_tim(const uint8_t type, uint8_t len, const uint8_t *data)
printf("\n");
}

+static void print_ibssatim(const uint8_t type, uint8_t len, const uint8_t *data)
+{
+ printf(" %d TUs", (data[1] << 8) + data[0]);
+}
+
static void print_vht_capa(const uint8_t type, uint8_t len, const uint8_t *data)
{
printf("\n");
@@ -791,11 +802,14 @@ static const struct ie_print ieprinters[] = {
[1] = { "Supported rates", print_supprates, 0, 255, BIT(PRINT_SCAN), },
[3] = { "DS Parameter set", print_ds, 1, 1, BIT(PRINT_SCAN), },
[5] = { "TIM", print_tim, 4, 255, BIT(PRINT_SCAN), },
+ [6] = { "IBSS ATIM window", print_ibssatim, 2, 2, BIT(PRINT_SCAN), },
[7] = { "Country", print_country, 3, 255, BIT(PRINT_SCAN), },
[11] = { "BSS Load", print_bss_load, 5, 5, BIT(PRINT_SCAN), },
[32] = { "Power constraint", print_powerconstraint, 1, 1, BIT(PRINT_SCAN), },
+ [35] = { "TPC report", print_tpcreport, 2, 2, BIT(PRINT_SCAN), },
[42] = { "ERP", print_erp, 1, 255, BIT(PRINT_SCAN), },
[45] = { "HT capabilities", print_ht_capa, 26, 26, BIT(PRINT_SCAN), },
+ [47] = { "ERP D4.0", print_erp, 1, 255, BIT(PRINT_SCAN), },
[74] = { "Overlapping BSS scan params", print_obss_scan_params, 14, 255, BIT(PRINT_SCAN), },
[61] = { "HT operation", print_ht_op, 22, 22, BIT(PRINT_SCAN), },
[62] = { "Secondary Channel Offset", print_secchan_offs, 1, 1, BIT(PRINT_SCAN), },
@@ -1378,7 +1393,7 @@ static int print_bss_handler(struct nl_msg *msg, void *arg)
is_dmg = true;
}
if (bss[NL80211_BSS_BEACON_INTERVAL])
- printf("\tbeacon interval: %d\n",
+ printf("\tbeacon interval: %d TUs\n",
nla_get_u16(bss[NL80211_BSS_BEACON_INTERVAL]));
if (bss[NL80211_BSS_CAPABILITY]) {
__u16 capa = nla_get_u16(bss[NL80211_BSS_CAPABILITY]);

2013-04-22 13:59:19

by Johannes Berg

Subject: Re: [PATCHv2] iw: Deocde some more IEs

On Fri, 2013-04-19 at 22:39 +0200, Joerg Mayer wrote:
> Small update, found while verifying against the standard.
>
> Thanks
> Jörg
>
> The results of a boring train ride:
> - Decode some IEs sent by other traveller's devices
> + IBSS ATIM window
> + TPC report
> + Old ERP IE (802.11g D4.0)
> - Tiny whitespace fix
> - Add Unit 'TUs' to beacon interval.

Nice, thanks. I changed the unit to just "TU" though :)

johannes

2013-04-22 13:59:58

by Johannes Berg

Subject: Re: [PATCHv2] iw: Deocde some more IEs

On Mon, 2013-04-22 at 15:59 +0200, Johannes Berg wrote:
> On Fri, 2013-04-19 at 22:39 +0200, Joerg Mayer wrote:
> > Small update, found while verifying against the standard.
> >
> > Thanks
> > Jörg
> >
> > The results of a boring train ride:
> > - Decode some IEs sent by other traveller's devices
> > + IBSS ATIM window
> > + TPC report
> > + Old ERP IE (802.11g D4.0)
> > - Tiny whitespace fix
> > - Add Unit 'TUs' to beacon interval.
>
> Nice, thanks. I changed the unit to just "TU" though :)

Actually, I changed my mind ;-) everything else seems to say "TUs" too

johannes