2013-10-23 10:12:37

by Dhahira Thesneem

Subject: [PATCH 1/1] mac80211:Resetting connection monitor timers in transmit path

Reset connection monitor timers when we are able to successfully transmit data to an AP.

Signed-off-by: Dhahira Thesneem <[email protected]>
---
net/mac80211/tx.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 3456c04..e7725cf 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1700,7 +1700,8 @@ netdev_tx_t ieee80211_monitor_start_xmit(struct sk_buff *skb,

ieee80211_xmit(sdata, skb, chan->band);
rcu_read_unlock();
-
+ /*To reset connection monitor timers, after successful transmission*/
+ ieee80211_sta_reset_conn_monitor(sdata);
return NETDEV_TX_OK;

fail_rcu:
@@ -2139,7 +2140,8 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,

ieee80211_xmit(sdata, skb, band);
rcu_read_unlock();
-
+ /*To reset connection monitor timers, after successful transmission*/
+ ieee80211_sta_reset_conn_monitor(sdata);
return NETDEV_TX_OK;

fail_rcu:
--
1.7.5.4

2013-10-23 10:54:45

by Krishna Chaitanya

Subject: Re: [PATCH 1/1] mac80211:Resetting connection monitor timers in transmit path

On Wed, Oct 23, 2013 at 3:42 PM, Dhahira Thesneem
<[email protected]> wrote:
>
> Reset connection monitor timers when we are able to successfully transmit data to an AP.
>
> Signed-off-by: Dhahira Thesneem <[email protected]>
> ---
> net/mac80211/tx.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 3456c04..e7725cf 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -1700,7 +1700,8 @@ netdev_tx_t ieee80211_monitor_start_xmit(struct sk_buff *skb,
>
> ieee80211_xmit(sdata, skb, chan->band);
> rcu_read_unlock();
> -
> + /*To reset connection monitor timers, after successful transmission*/
> + ieee80211_sta_reset_conn_monitor(sdata);
> return NETDEV_TX_OK;
>
> fail_rcu:
> @@ -2139,7 +2140,8 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,
>
> ieee80211_xmit(sdata, skb, band);
> rcu_read_unlock();
> -
> + /*To reset connection monitor timers, after successful transmission*/
> + ieee80211_sta_reset_conn_monitor(sdata);
> return NETDEV_TX_OK;
>
> fail_rcu:
> --
Successful data transmission should be checked in the tx_status not
after we transmit.
In fact its already taken care in status.c: through ieee80211_sta_tx_notify.

NACK.