2015-09-13 10:59:39

by Aparna Karuthodi

[permalink] [raw]
Subject: [PATCH] staging: wilc1000: Added a new line

Added a new line after declaration to remove a coding style warning
detected by checkpatch. The warning is given below
WARNING: Missing a blank line after declarations

Signed-off-by: Aparna Karuthodi <[email protected]>
---
drivers/staging/wilc1000/coreconfigurator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index ed6ac45..0c964c6 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -2101,6 +2101,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
u32 u32WIDsCount, bool bRespRequired, u32 drvHandler)
{
s32 counter = 0, ret = 0;
+
if (gpstrWlanOps == NULL) {
PRINT_D(CORECONFIG_DBG, "Net Dev is still not initialized\n");
return 1;
--
1.7.9.5



2015-09-14 04:46:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: wilc1000: Added a new line

On Sun, Sep 13, 2015 at 04:31:33PM +0530, Aparna Karuthodi wrote:
> Added a new line after declaration to remove a coding style warning
> detected by checkpatch. The warning is given below
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index ed6ac45..0c964c6 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -2101,6 +2101,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
> u32 u32WIDsCount, bool bRespRequired, u32 drvHandler)
> {
> s32 counter = 0, ret = 0;
> +
> if (gpstrWlanOps == NULL) {
> PRINT_D(CORECONFIG_DBG, "Net Dev is still not initialized\n");
> return 1;

someone already sent in this change before you did, sorry.