2017-02-27 17:16:26

by Zefir Kurtisi

Subject: [PATCH] ath9k: don't trigger spectral scan when not enabled

Doing so enables the FFT generation without prior
configuration, leading to an IRQ storm caused by
invalid (or at least unwanted) PHY errors.

Signed-off-by: Zefir Kurtisi <[email protected]>
---
drivers/net/wireless/ath/ath9k/common-spectral.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/common-spectral.c b/drivers/net/wireless/ath/ath9k/common-spectral.c
index 58f1ed1..51b618c 100644
--- a/drivers/net/wireless/ath/ath9k/common-spectral.c
+++ b/drivers/net/wireless/ath/ath9k/common-spectral.c
@@ -739,6 +739,9 @@ void ath9k_cmn_spectral_scan_trigger(struct ath_common *common,
return;
}

+ if (!spec_priv->spec_config.enabled)
+ return;
+
ath_ps_ops(common)->wakeup(common);
rxfilter = ath9k_hw_getrxfilter(ah);
ath9k_hw_setrxfilter(ah, rxfilter |
--
2.7.4

2017-03-16 08:58:22

by Kalle Valo

Subject: Re: ath9k: don't trigger spectral scan when not enabled

Zefir Kurtisi <[email protected]> wrote:
> Doing so enables the FFT generation without prior
> configuration, leading to an IRQ storm caused by
> invalid (or at least unwanted) PHY errors.
>
> Signed-off-by: Zefir Kurtisi <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

45c3d550b068 ath9k: don't trigger spectral scan when not enabled

--
https://patchwork.kernel.org/patch/9593623/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches