2018-05-07 09:36:03

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH 00/18] Fix some build warnings/errors with Sphinx

I decided to give a try with Sphinx last stable version
(1.17.4), and noticed several issues. The worse one was
with the networking book: a non-standard footnote there
with [*] instead of a number causes it to break PDF building.

So, I took some spare time to address some warnings all over
the tree, and moved a few text documents to a book. I with
I had more time to move the other ones and to solve other
warnings.

Mauro Carvalho Chehab (18):
docs: can.rst: fix a footnote reference
docs: fix location of request_firmware & friends
docs: */index.rst: Add newer documents to their respective index.rst
docs: admin-guide: add bcache documentation
docs: core-api: add cachetlb documentation
docs: core-api: add cgroup-v2 documentation
docs: core-api: add circular-buffers documentation
docs: driver-api: add clk documentation
net: mac80211.h: fix a bad comment line
rcu: rcupdate.h: get rid of Sphinx warnings at rcu_pointer_handoff()
docs: crypto_engine.rst: Fix two parse warnings
time: timer.c: adjust a kernel-doc comment
wait: wait.h: Get rid of a kernel-doc/Sphinx warnings
fbdev: modedb.c: fix a kernel-doc markup
iio: iio.h: use nested struct support on kernel-doc markup
mtd: rawnand.h: use nested union kernel-doc markups
docs: uio-howto.rst: use a code block to solve a warning
w1: w1_io.c: fix a kernel-doc warning

Documentation/00-INDEX | 10 -------
.../{bcache.txt => admin-guide/bcache.rst} | 0
.../cgroup-v2.rst} | 0
Documentation/admin-guide/index.rst | 2 ++
.../admin-guide/kernel-parameters.txt | 2 +-
.../{cachetlb.txt => core-api/cachetlb.rst} | 0
.../circular-buffers.rst} | 0
Documentation/core-api/index.rst | 2 ++
Documentation/crypto/crypto_engine.rst | 8 +++---
Documentation/crypto/index.rst | 1 +
Documentation/dell_rbu.txt | 4 +--
Documentation/{clk.txt => driver-api/clk.rst} | 0
.../firmware/fallback-mechanisms.rst | 2 +-
.../driver-api/firmware/request_firmware.rst | 17 +++++++-----
Documentation/driver-api/index.rst | 2 ++
Documentation/driver-api/infrastructure.rst | 2 +-
Documentation/driver-api/uio-howto.rst | 3 ++-
Documentation/memory-barriers.txt | 4 +--
Documentation/networking/can.rst | 4 +--
.../power/suspend-and-cpuhotplug.txt | 2 +-
Documentation/process/index.rst | 1 +
Documentation/security/index.rst | 2 ++
.../translations/ko_KR/memory-barriers.txt | 4 +--
drivers/video/fbdev/core/modedb.c | 22 ++++++++--------
drivers/w1/w1_io.c | 1 +
include/linux/iio/iio.h | 24 ++++++++---------
include/linux/mtd/rawnand.h | 26 +++++++++++++------
include/linux/rcupdate.h | 5 ++--
include/linux/wait.h | 2 +-
include/net/mac80211.h | 2 +-
kernel/time/timer.c | 14 +++++-----
31 files changed, 93 insertions(+), 75 deletions(-)
rename Documentation/{bcache.txt => admin-guide/bcache.rst} (100%)
rename Documentation/{cgroup-v2.txt => admin-guide/cgroup-v2.rst} (100%)
rename Documentation/{cachetlb.txt => core-api/cachetlb.rst} (100%)
rename Documentation/{circular-buffers.txt => core-api/circular-buffers.rst} (100%)
rename Documentation/{clk.txt => driver-api/clk.rst} (100%)

--
2.17.0


2018-05-07 12:38:42

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH 09/18] net: mac80211.h: fix a bad comment line

On Mon, 2018-05-07 at 15:37 +0300, Kalle Valo wrote:
> Mauro Carvalho Chehab <[email protected]> writes:
>
> > Sphinx produces a lot of errors like this:
> > ./include/net/mac80211.h:2083: warning: bad line: >
> >
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> Randy already submitted a similar patch:
>
> https://patchwork.kernel.org/patch/10367275/
>
> But it seems Johannes has not applied that yet.

Yeah, I've been super busy preparing for the plugfest.

I'll make a pass over all the patches as soon as I can, hopefully today
or tomorrow.

johannes

2018-05-07 12:37:54

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 09/18] net: mac80211.h: fix a bad comment line

Mauro Carvalho Chehab <[email protected]> writes:

> Sphinx produces a lot of errors like this:
> ./include/net/mac80211.h:2083: warning: bad line: >
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Randy already submitted a similar patch:

https://patchwork.kernel.org/patch/10367275/

But it seems Johannes has not applied that yet.

--
Kalle Valo

2018-05-09 12:04:08

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH 09/18] net: mac80211.h: fix a bad comment line

Em Mon, 07 May 2018 14:38:26 +0200
Johannes Berg <[email protected]> escreveu:

> On Mon, 2018-05-07 at 15:37 +0300, Kalle Valo wrote:
> > Mauro Carvalho Chehab <[email protected]> writes:
> >
> > > Sphinx produces a lot of errors like this:
> > > ./include/net/mac80211.h:2083: warning: bad line: >
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> >
> > Randy already submitted a similar patch:
> >
> > https://patchwork.kernel.org/patch/10367275/
> >
> > But it seems Johannes has not applied that yet.
>
> Yeah, I've been super busy preparing for the plugfest.
>
> I'll make a pass over all the patches as soon as I can, hopefully today
> or tomorrow.

Thanks. I'll drop it from my patchset, assuming that you'll
be applying Randy's version or mine via your tree.

Thanks,
Mauro

2018-05-08 16:13:46

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH 00/18] Fix some build warnings/errors with Sphinx

On Mon, 7 May 2018 06:35:36 -0300
Mauro Carvalho Chehab <[email protected]> wrote:

> I decided to give a try with Sphinx last stable version
> (1.17.4), and noticed several issues. The worse one was
> with the networking book: a non-standard footnote there
> with [*] instead of a number causes it to break PDF building.
>
> So, I took some spare time to address some warnings all over
> the tree, and moved a few text documents to a book.

OK, I've applied the ones that seem to make sense for me to take now.
There's comments on the firmware one, and I'd rather have Tejun's OK for
the cgroup one. The code-comment changes should probably go via the
usual maintainers.

> I with
> I had more time to move the other ones and to solve other
> warnings.

You and me both - but each step helps!

Thanks,

jon

2018-05-07 09:36:12

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH 09/18] net: mac80211.h: fix a bad comment line

Sphinx produces a lot of errors like this:
./include/net/mac80211.h:2083: warning: bad line: >

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
include/net/mac80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index d2279b2d61aa..b2f3a0c018e7 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -2080,7 +2080,7 @@ struct ieee80211_txq {
* virtual interface might not be given air time for the transmission of
* the frame, as it is not synced with the AP/P2P GO yet, and thus the
* deauthentication frame might not be transmitted.
- >
+ *
* @IEEE80211_HW_DOESNT_SUPPORT_QOS_NDP: The driver (or firmware) doesn't
* support QoS NDP for AP probing - that's most likely a driver bug.
*
--
2.17.0

2018-05-09 12:04:45

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH 09/18] net: mac80211.h: fix a bad comment line

On Wed, 2018-05-09 at 09:04 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 07 May 2018 14:38:26 +0200
> Johannes Berg <[email protected]> escreveu:
>
> > On Mon, 2018-05-07 at 15:37 +0300, Kalle Valo wrote:
> > > Mauro Carvalho Chehab <[email protected]> writes:
> > >
> > > > Sphinx produces a lot of errors like this:
> > > > ./include/net/mac80211.h:2083: warning: bad line: >
> > > >
> > > > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> > >
> > > Randy already submitted a similar patch:
> > >
> > > https://patchwork.kernel.org/patch/10367275/
> > >
> > > But it seems Johannes has not applied that yet.
> >
> > Yeah, I've been super busy preparing for the plugfest.
> >
> > I'll make a pass over all the patches as soon as I can, hopefully today
> > or tomorrow.
>
> Thanks. I'll drop it from my patchset, assuming that you'll
> be applying Randy's version or mine via your tree.

Right, I did, just need to send a pull request.

johannes

2018-05-08 17:36:52

by Luis Chamberlain

[permalink] [raw]
Subject: Re: [PATCH 00/18] Fix some build warnings/errors with Sphinx

On Tue, May 08, 2018 at 10:13:42AM -0600, Jonathan Corbet wrote:
> On Mon, 7 May 2018 06:35:36 -0300
> Mauro Carvalho Chehab <[email protected]> wrote:
>
> > I decided to give a try with Sphinx last stable version
> > (1.17.4), and noticed several issues. The worse one was
> > with the networking book: a non-standard footnote there
> > with [*] instead of a number causes it to break PDF building.
> >
> > So, I took some spare time to address some warnings all over
> > the tree, and moved a few text documents to a book.
>
> OK, I've applied the ones that seem to make sense for me to take now.
> There's comments on the firmware one,

I'll fold in the fixes for the firmware API which do apply to my queue.

Luis