2020-04-14 03:57:11

by Govindaraj Saminathan

Subject: [PATCH] ath11k: cleanup reo command error code overwritten

should not overwrite the error code. No buffer available then return
invalid. For other failures return the error code of actual failure.

Signed-off-by: Govindaraj Saminathan <[email protected]>
---
drivers/net/wireless/ath/ath11k/dp_tx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
index 7aac4b0..6f40e72 100644
--- a/drivers/net/wireless/ath/ath11k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
@@ -543,8 +543,12 @@ int ath11k_dp_tx_send_reo_cmd(struct ath11k_base *ab, struct dp_rx_tid *rx_tid,
cmd_ring = &ab->hal.srng_list[dp->reo_cmd_ring.ring_id];
cmd_num = ath11k_hal_reo_cmd_send(ab, cmd_ring, type, cmd);

+ /* cmd_num should start from 1, during failure return the error code */
+ if (cmd_num < 0)
+ return cmd_num;
+
/* reo cmd ring descriptors has cmd_num starting from 1 */
- if (cmd_num <= 0)
+ if (cmd_num == 0)
return -EINVAL;

if (!cb)
--
1.9.1

2020-04-15 22:26:22

by Kalle Valo

Subject: Re: [PATCH] ath11k: cleanup reo command error code overwritten

Govindaraj Saminathan <[email protected]> wrote:

> should not overwrite the error code. No buffer available then return
> invalid. For other failures return the error code of actual failure.
>
> Signed-off-by: Govindaraj Saminathan <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

e190bc05b191 ath11k: cleanup reo command error code overwritten

--
https://patchwork.kernel.org/patch/11485447/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches