2021-04-15 13:42:21

by Sean Wang

[permalink] [raw]
Subject: [PATCH 1/2] mt76: mt7921: add debugfs knob for performing wifi reset

From: Sean Wang <[email protected]>

Introduce chip_reset knob in mt7921 debugfs to export a way to users
able to trigger wifi reset.

Signed-off-by: Sean Wang <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
index 024524173115..1342a0b645e3 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
@@ -302,6 +302,16 @@ static int mt7921_config(void *data, u64 val)

DEFINE_DEBUGFS_ATTRIBUTE(fops_config, NULL, mt7921_config, "%lld\n");

+static int mt7921_chip_reset(void *data, u64 val)
+{
+ struct mt7921_dev *dev = data;
+
+ mt7921_reset(&dev->mt76);
+
+ return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(fops_reset, NULL, mt7921_chip_reset, "%lld\n");
+
int mt7921_init_debugfs(struct mt7921_dev *dev)
{
struct dentry *dir;
@@ -322,6 +332,7 @@ int mt7921_init_debugfs(struct mt7921_dev *dev)
debugfs_create_file("idle-timeout", 0600, dir, dev,
&fops_pm_idle_timeout);
debugfs_create_file("chip_config", 0600, dir, dev, &fops_config);
+ debugfs_create_file("chip_reset", 0600, dir, dev, &fops_reset);

return 0;
}
--
2.25.1


2021-04-15 13:55:22

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 1/2] mt76: mt7921: add debugfs knob for performing wifi reset

> From: Sean Wang <[email protected]>
>
> Introduce chip_reset knob in mt7921 debugfs to export a way to users
> able to trigger wifi reset.
>
> Signed-off-by: Sean Wang <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> index 024524173115..1342a0b645e3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> @@ -302,6 +302,16 @@ static int mt7921_config(void *data, u64 val)
>
> DEFINE_DEBUGFS_ATTRIBUTE(fops_config, NULL, mt7921_config, "%lld\n");
>
> +static int mt7921_chip_reset(void *data, u64 val)
> +{
> + struct mt7921_dev *dev = data;
> +
> + mt7921_reset(&dev->mt76);
> +
> + return 0;
> +}
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_reset, NULL, mt7921_chip_reset, "%lld\n");

can we use chip_config for this?

Regards,
Lorenzo

> +
> int mt7921_init_debugfs(struct mt7921_dev *dev)
> {
> struct dentry *dir;
> @@ -322,6 +332,7 @@ int mt7921_init_debugfs(struct mt7921_dev *dev)
> debugfs_create_file("idle-timeout", 0600, dir, dev,
> &fops_pm_idle_timeout);
> debugfs_create_file("chip_config", 0600, dir, dev, &fops_config);
> + debugfs_create_file("chip_reset", 0600, dir, dev, &fops_reset);
>
> return 0;
> }
> --
> 2.25.1
>


Attachments:
(No filename) (1.47 kB)
signature.asc (235.00 B)
Download all attachments

2021-04-15 14:56:12

by Sean Wang

[permalink] [raw]
Subject: Re: [PATCH 1/2] mt76: mt7921: add debugfs knob for performing wifi reset

From: Sean Wang <[email protected]>

>> From: Sean Wang <[email protected]>
>>
>> Introduce chip_reset knob in mt7921 debugfs to export a way to users
>> able to trigger wifi reset.
>>
>> Signed-off-by: Sean Wang <[email protected]>
>> ---
>> drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
>> b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
>> index 024524173115..1342a0b645e3 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
>> @@ -302,6 +302,16 @@ static int mt7921_config(void *data, u64 val)
>>
>> DEFINE_DEBUGFS_ATTRIBUTE(fops_config, NULL, mt7921_config, "%lld\n");
>>
>> +static int mt7921_chip_reset(void *data, u64 val) {
>> + struct mt7921_dev *dev = data;
>> +
>> + mt7921_reset(&dev->mt76);
>> +
>> + return 0;
>> +}
>> +DEFINE_DEBUGFS_ATTRIBUTE(fops_reset, NULL, mt7921_chip_reset,
>> +"%lld\n");
>
>can we use chip_config for this?

i think we can resue the the knob for chip_reset. i will do it in the next version.

>
>Regards,
>Lorenzo
>
>> +
>> int mt7921_init_debugfs(struct mt7921_dev *dev) {
>> struct dentry *dir;
>> @@ -322,6 +332,7 @@ int mt7921_init_debugfs(struct mt7921_dev *dev)
>> debugfs_create_file("idle-timeout", 0600, dir, dev,
>> &fops_pm_idle_timeout);
>> debugfs_create_file("chip_config", 0600, dir, dev, &fops_config);
>> + debugfs_create_file("chip_reset", 0600, dir, dev, &fops_reset);
>>
>> return 0;
>> }
>> --
>> 2.25.1
>>
>

2021-04-15 15:13:15

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 1/2] mt76: mt7921: add debugfs knob for performing wifi reset

> From: Sean Wang <[email protected]>
>
> >> From: Sean Wang <[email protected]>
> >>
> >> Introduce chip_reset knob in mt7921 debugfs to export a way to users
> >> able to trigger wifi reset.
> >>
> >> Signed-off-by: Sean Wang <[email protected]>
> >> ---
> >> drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> >> b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> >> index 024524173115..1342a0b645e3 100644
> >> --- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> >> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
> >> @@ -302,6 +302,16 @@ static int mt7921_config(void *data, u64 val)
> >>
> >> DEFINE_DEBUGFS_ATTRIBUTE(fops_config, NULL, mt7921_config, "%lld\n");
> >>
> >> +static int mt7921_chip_reset(void *data, u64 val) {
> >> + struct mt7921_dev *dev = data;
> >> +
> >> + mt7921_reset(&dev->mt76);
> >> +
> >> + return 0;
> >> +}
> >> +DEFINE_DEBUGFS_ATTRIBUTE(fops_reset, NULL, mt7921_chip_reset,
> >> +"%lld\n");
> >
> >can we use chip_config for this?
>
> i think we can resue the the knob for chip_reset. i will do it in the next version.

ack, I agree. Please rename the chip_config in something lile reset or similar.

Thanks,
Lorenzo

>
> >
> >Regards,
> >Lorenzo
> >
> >> +
> >> int mt7921_init_debugfs(struct mt7921_dev *dev) {
> >> struct dentry *dir;
> >> @@ -322,6 +332,7 @@ int mt7921_init_debugfs(struct mt7921_dev *dev)
> >> debugfs_create_file("idle-timeout", 0600, dir, dev,
> >> &fops_pm_idle_timeout);
> >> debugfs_create_file("chip_config", 0600, dir, dev, &fops_config);
> >> + debugfs_create_file("chip_reset", 0600, dir, dev, &fops_reset);
> >>
> >> return 0;
> >> }
> >> --
> >> 2.25.1
> >>
> >


Attachments:
(No filename) (1.83 kB)
signature.asc (235.00 B)
Download all attachments