2022-01-12 22:33:59

by CGEL

Subject: [PATCH] wireless/ath/ath9k: remove redundant status variable

From: Minghao Chi <[email protected]>

Return value directly instead of taking this in another redundant
variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
Signed-off-by: CGEL ZTE <[email protected]>
---
drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c
index e6b3cd49ea18..efb7889142d4 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom.c
@@ -670,8 +670,6 @@ void ath9k_hw_get_gain_boundaries_pdadcs(struct ath_hw *ah,

int ath9k_hw_eeprom_init(struct ath_hw *ah)
{
- int status;
-
if (AR_SREV_9300_20_OR_LATER(ah))
ah->eep_ops = &eep_ar9300_ops;
else if (AR_SREV_9287(ah)) {
@@ -685,7 +683,5 @@ int ath9k_hw_eeprom_init(struct ath_hw *ah)
if (!ah->eep_ops->fill_eeprom(ah))
return -EIO;

- status = ah->eep_ops->check_eeprom(ah);
-
- return status;
+ return ah->eep_ops->check_eeprom(ah);
}
--
2.25.1

2022-01-12 22:34:58

by Kalle Valo

Subject: Re: [PATCH] wireless/ath/ath9k: remove redundant status variable

[email protected] writes:

> From: Minghao Chi <[email protected]>
>
> Return value directly instead of taking this in another redundant
> variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: CGEL ZTE <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

The subject prefix should be "ath9k:", I can fix that.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-01-18 02:25:08

by Kalle Valo

Subject: Re: [PATCH] wireless/ath/ath9k: remove redundant status variable

[email protected] wrote:

> Return value directly instead of taking this in another redundant
> variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: CGEL ZTE <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

76d7b996aab8 ath9k: remove redundant status variable

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches