2022-09-12 02:25:32

by Ping-Ke Shih

Subject: [PATCH] wifi: rtw89: coex: show connecting state in debug message

The variable cnt_connecting is to indicate if we are connecting to an AP.
This is an important clue for coexistence to assign more time slot to WiFi
side in this situation to ensure WiFi can establish connection.

Without this patch, compiler warns:
drivers/net/wireless/realtek/rtw89/coex.c:3244:25: warning: variable
'cnt_connecting' set but not used [-Wunused-but-set-variable]

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Ping-Ke Shih <[email protected]>
---
drivers/net/wireless/realtek/rtw89/coex.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/coex.c b/drivers/net/wireless/realtek/rtw89/coex.c
index 732502b64b255..e3d1b165c322e 100644
--- a/drivers/net/wireless/realtek/rtw89/coex.c
+++ b/drivers/net/wireless/realtek/rtw89/coex.c
@@ -4088,8 +4088,8 @@ static void _update_wl_info(struct rtw89_dev *rtwdev)
}

rtw89_debug(rtwdev, RTW89_DBG_BTC,
- "[BTC], cnt_connect = %d, link_mode = %d\n",
- cnt_connect, wl_rinfo->link_mode);
+ "[BTC], cnt_connect = %d, connecting = %d, link_mode = %d\n",
+ cnt_connect, cnt_connecting, wl_rinfo->link_mode);

_fw_set_drv_info(rtwdev, CXDRVINFO_ROLE);
}
--
2.25.1

2022-09-19 10:05:04

by Kalle Valo

Subject: Re: [PATCH] wifi: rtw89: coex: show connecting state in debug message

Ping-Ke Shih <[email protected]> wrote:

> The variable cnt_connecting is to indicate if we are connecting to an AP.
> This is an important clue for coexistence to assign more time slot to WiFi
> side in this situation to ensure WiFi can establish connection.
>
> Without this patch, compiler warns:
> drivers/net/wireless/realtek/rtw89/coex.c:3244:25: warning: variable
> 'cnt_connecting' set but not used [-Wunused-but-set-variable]
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-next.git, thanks.

bc012b16c15f wifi: rtw89: coex: show connecting state in debug message

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches