2007-02-17 17:50:11

by Stefano Brivio

[permalink] [raw]
Subject: [PATCH] bcm43xx: fix for 4309

BCM4309 devices aren't working properly as A PHYs aren't supported yet, but
we probe 802.11a cores anyway. This fixes it, while still allowing for A PHY code
to be developed in the future.

Signed-off-by: Stefano Brivio <[email protected]>
----

John,

This is actually a bugfix so I think it should make into 2.6.21. This makes
BCM4309 cards working.

--
Ciao
Stefano

----

--- linux-2.6.20/drivers/net/wireless/bcm43xx/bcm43xx_main.c.orig 2007-02-17 18:05:21.872891550 +0100
+++ linux-2.6.20/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2007-02-17 18:14:59.620752491 +0100
@@ -2741,8 +2741,9 @@
* dangling pins on the second core. Be careful
* and ignore these cores here.
*/
- if (bcm->pci_dev->device != 0x4324) {
- dprintk(KERN_INFO PFX "Ignoring additional 802.11 core.\n");
+ if (1 /*bcm->pci_dev->device != 0x4324*/ ) {
+ /* TODO: A PHY */
+ dprintk(KERN_INFO PFX "Ignoring additional 802.11a core.\n");
continue;
}
}


2007-02-17 17:46:31

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] bcm43xx: fix for 4309

Stefano Brivio wrote:
> BCM4309 devices aren't working properly as A PHYs aren't supported yet, but
> we probe 802.11a cores anyway. This fixes it, while still allowing for A PHY code
> to be developed in the future.
>
> Signed-off-by: Stefano Brivio <[email protected]>
Signed-off-by: Larry Finger<[email protected]>
> ----
>
> John,
>
> This is actually a bugfix so I think it should make into 2.6.21. This makes
> BCM4309 cards working.
>

--- linux-2.6.20/drivers/net/wireless/bcm43xx/bcm43xx_main.c.orig 2007-02-17 18:05:21.872891550 +0100
+++ linux-2.6.20/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2007-02-17 18:14:59.620752491 +0100
@@ -2741,8 +2741,9 @@
* dangling pins on the second core. Be careful
* and ignore these cores here.
*/
- if (bcm->pci_dev->device != 0x4324) {
- dprintk(KERN_INFO PFX "Ignoring additional 802.11 core.\n");
+ if (1 /*bcm->pci_dev->device != 0x4324*/ ) {
+ /* TODO: A PHY */
+ dprintk(KERN_INFO PFX "Ignoring additional 802.11a core.\n");
continue;
}
}
_______________________________________________