2007-03-23 19:28:22

by Stefano Brivio

Subject: [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq

Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are
already leftshifted. Thanks to Michael Buesch for spotting this.

Signed-off-by: Stefano Brivio <[email protected]>

---

diff --git a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
index 10a82b1..a2c52f6 100644
--- a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
+++ b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
@@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4

for (i = 0; i < 5; i++) {
for (j = 0; j < 5; j++) {
- if (tmp == (data_high[i] << 4 | data_low[j])) {
+ if (tmp == (data_high[i] | data_low[j])) {
bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
return;
}

2007-03-23 20:26:16

by Michael Büsch

Subject: Re: [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq

On Friday 23 March 2007 20:23, Stefano Brivio wrote:
> Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are
> already leftshifted. Thanks to Michael Buesch for spotting this.
>
> Signed-off-by: Stefano Brivio <[email protected]>

I think you should probably write your APHY stuff against the development
tree, as only that has proper support for multiple 802.11 cores (4309).

> diff --git a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> index 10a82b1..a2c52f6 100644
> --- a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> +++ b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> @@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4
>
> for (i = 0; i < 5; i++) {
> for (j = 0; j < 5; j++) {
> - if (tmp == (data_high[i] << 4 | data_low[j])) {
> + if (tmp == (data_high[i] | data_low[j])) {
> bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
> return;
> }

--
Greetings Michael.