2007-04-20 02:29:54

by Tim Gardner

[permalink] [raw]

Subject: PATCH [001/001] - Remove duplicate rtnl_unlock()

---

Remove a duplicate rtnl_unlock().

Signed-off-by: [email protected]

---

diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index b5a62b7..cf3d020 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -4816,7 +4816,6 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
rtnl_lock();
result = dev_alloc_name(local->mdev, local->mdev->name);
if (result < 0) {
- rtnl_unlock();
goto fail_dev;
}

---

Attachments:

duplicate_unlock.txt (446.00 B)

2007-04-23 18:22:28

by Jiri Benc

[permalink] [raw]

Subject: Re: PATCH [001/001] - Remove duplicate rtnl_unlock()

---

On Thu, 19 Apr 2007 20:29:50 -0600, Tim Gardner wrote:
> Remove a duplicate rtnl_unlock().
>
> Signed-off-by: [email protected]

Please use the "Name <mail>" form of the Signed-off-by line.

> diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
> index b5a62b7..cf3d020 100644
> --- a/net/mac80211/ieee80211.c
> +++ b/net/mac80211/ieee80211.c
> @@ -4816,7 +4816,6 @@ int ieee80211_register_hw(struct ieee80211_hw
> *hw) rtnl_lock();
> result = dev_alloc_name(local->mdev, local->mdev->name);
> if (result < 0) {
> - rtnl_unlock();
> goto fail_dev;
> }

Please remove the enclosing braces too.

Thanks,

Jiri

--
Jiri Benc
SUSE Labs