Don't call ieee80211_sta_find_ibss() directly, like it's done in STA mo=
de, so that the commit() call is more harmless respectively has less si=
te-effects.
Signed-off-by: Alina Friedrichsen <[email protected]>
---
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index f4becc1..3201e1f 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -812,8 +812,9 @@ int ieee80211_ibss_commit(struct ieee80211_sub_if_d=
ata *sdata)
=20
ifibss->ibss_join_req =3D jiffies;
ifibss->state =3D IEEE80211_IBSS_MLME_SEARCH;
+ set_bit(IEEE80211_IBSS_REQ_RUN, &ifibss->request);
=20
- return ieee80211_sta_find_ibss(sdata);
+ return 0;
}
=20
int ieee80211_ibss_set_ssid(struct ieee80211_sub_if_data *sdata, char =
*ssid, size_t len)
--=20
Psssst! Schon vom neuen GMX MultiMessenger geh=F6rt? Der kann`s mit all=
en: http://www.gmx.net/de/go/multimessenger01
Hello!
> And now to explain why this is desired?
=46or unification with the STA implementation and besides it fixes a bu=
g, that ieee80211_sta_find_ibss() is triggered while the interface is d=
own and do some strange things that it shouldn't do in this interface s=
tate.
> Are you going to post "commit"
> patches again that I will reject?
This has nothing to do with the current patch and should discussed else=
where.
Regards
Alina
--=20
Psssst! Schon vom neuen GMX MultiMessenger geh=F6rt? Der kann`s mit all=
en: http://www.gmx.net/de/go/multimessenger01
Hello Johannes!
> > For unification with the STA implementation=20
>=20
> FWIW, I don't see that as something that is necessarily desirable, I'=
ve
> split them up to allow them to diverge further and in a manageable wa=
y.
I mean not the code itself but the coding style. So that you can better=
understand the code of the one mode, if you read the code of the other=
mode before. Sorry, for my bad English.
Regards
Alina
--=20
Nur bis 16.03.! DSL-Komplettanschluss inkl. WLAN-Modem f=FCr nur=20
17,95 =BF/mtl. + 1 Monat gratis!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K1=
1308T4569a
On Tue, 2009-03-10 at 23:44 +0100, Alina Friedrichsen wrote:
> Hello!
>
> > And now to explain why this is desired?
>
> For unification with the STA implementation
FWIW, I don't see that as something that is necessarily desirable, I've
split them up to allow them to diverge further and in a manageable way.
> and besides it fixes a bug, that ieee80211_sta_find_ibss() is
> triggered while the interface is down and do some strange things that
> it shouldn't do in this interface state.
Indeed, good point, that can happen without this patch.
johannes
On Tue, 2009-03-10 at 00:49 +0100, Alina Friedrichsen wrote:
> Don't call ieee80211_sta_find_ibss() directly, like it's done in STA
> mode, so that the commit() call is more harmless respectively has less
> site-effects.
And now to explain why this is desired? Are you going to post "commit"
patches again that I will reject?
johannes