2013-06-06 10:53:09

by Dan Carpenter

[permalink] [raw]
Subject: [patch] cw1200: remove an unreachable goto

The "return" is correct and the unreachable "goto" line is wrong.
I have deleted it.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/net/wireless/cw1200/hwio.c b/drivers/net/wireless/cw1200/hwio.c
index 1af7b3d..f6b5efd 100644
--- a/drivers/net/wireless/cw1200/hwio.c
+++ b/drivers/net/wireless/cw1200/hwio.c
@@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf,
if ((buf_len / 2) >= 0x1000) {
pr_err("Can't read more than 0xfff words.\n");
return -EINVAL;
- goto out;
}

priv->sbus_ops->lock(priv->sbus_priv);


2013-06-06 10:55:45

by Solomon Peachy

[permalink] [raw]
Subject: Re: [patch] cw1200: remove an unreachable goto

On Thu, Jun 06, 2013 at 03:51:45AM -0700, Dan Carpenter wrote:
> The "return" is correct and the unreachable "goto" line is wrong.
> I have deleted it.

A patch for this was posted earlier by Joe Perches. It's in my tree
now, awaiting merging.

- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.


Attachments:
(No filename) (425.00 B)
(No filename) (190.00 B)
Download all attachments