2014-09-16 23:19:28

by Mark Brown

[permalink] [raw]
Subject: [PATCH] hostap: proc: Remove unused variable

Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
variable i has been unused in prism2_bss_list_proc_show() so remove it.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/net/wireless/hostap/hostap_proc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
index 3a23a6d..dd84557 100644
--- a/drivers/net/wireless/hostap/hostap_proc.c
+++ b/drivers/net/wireless/hostap/hostap_proc.c
@@ -168,7 +168,6 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
local_info_t *local = m->private;
struct list_head *ptr = v;
struct hostap_bss_info *bss;
- int i;

if (ptr == &local->bss_list) {
seq_printf(m, "#BSSID\tlast_update\tcount\tcapab_info\tSSID(txt)\t"
--
2.1.0



2014-09-30 17:00:12

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH] hostap: proc: Remove unused variable

On Tue, Sep 16, 2014 at 04:16:55PM -0700, Mark Brown wrote:
> Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
> variable i has been unused in prism2_bss_list_proc_show() so remove it.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/net/wireless/hostap/hostap_proc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> index 3a23a6d..dd84557 100644
> --- a/drivers/net/wireless/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/hostap/hostap_proc.c
> @@ -168,7 +168,6 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
> local_info_t *local = m->private;
> struct list_head *ptr = v;
> struct hostap_bss_info *bss;
> - int i;
>
> if (ptr == &local->bss_list) {
> seq_printf(m, "#BSSID\tlast_update\tcount\tcapab_info\tSSID(txt)\t"
> --
> 2.1.0

What tree are you using? In wireless-next, I still see a loop in
that function using i as an index variable.

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2014-09-30 22:57:04

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] hostap: proc: Remove unused variable

On Tue, Sep 30, 2014 at 12:56:26PM -0400, John W. Linville wrote:
> On Tue, Sep 16, 2014 at 04:16:55PM -0700, Mark Brown wrote:

> > Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
> > variable i has been unused in prism2_bss_list_proc_show() so remove it.

> What tree are you using? In wireless-next, I still see a loop in
> that function using i as an index variable.

This was in -next for whatever day I sent that.


Attachments:
(No filename) (440.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments