2014-12-21 12:56:53

by Rickard Strandqvist

Subject: [PATCH] staging: rtl8723au: hal: rtl8723au_led.c: Remove some unused functions

Removes some functions that are not used anywhere:
rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/staging/rtl8723au/hal/rtl8723au_led.c | 23 ----------------------
drivers/staging/rtl8723au/include/rtl8723a_led.h | 2 --
2 files changed, 25 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_led.c b/drivers/staging/rtl8723au/hal/rtl8723au_led.c
index b946636..99d627a7 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723au_led.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723au_led.c
@@ -99,26 +99,3 @@ exit:

/* Interface to manipulate LED objects. */

-/* Description: */
-/* Initialize all LED_871x objects. */
-void
-rtl8723au_InitSwLeds(struct rtw_adapter *padapter)
-{
- struct led_priv *pledpriv = &padapter->ledpriv;
-
- pledpriv->LedControlHandler = LedControl871x23a;
- /* 8723as-vau wifi used led2 */
- InitLed871x23a(padapter, &pledpriv->SwLed0, LED_PIN_LED2);
-
-/* InitLed871x23a(padapter,&pledpriv->SwLed1, LED_PIN_LED2); */
-}
-
-/* Description: */
-/* DeInitialize all LED_819xUsb objects. */
-void
-rtl8723au_DeInitSwLeds(struct rtw_adapter *padapter)
-{
- struct led_priv *ledpriv = &padapter->ledpriv;
-
- DeInitLed871x23a(&ledpriv->SwLed0);
-}
diff --git a/drivers/staging/rtl8723au/include/rtl8723a_led.h b/drivers/staging/rtl8723au/include/rtl8723a_led.h
index 1623d18..c83efe6 100644
--- a/drivers/staging/rtl8723au/include/rtl8723a_led.h
+++ b/drivers/staging/rtl8723au/include/rtl8723a_led.h
@@ -22,8 +22,6 @@
/* */
/* Interface to manipulate LED objects. */
/* */
-void rtl8723au_InitSwLeds(struct rtw_adapter *padapter);
-void rtl8723au_DeInitSwLeds(struct rtw_adapter *padapter);
void SwLedOn23a(struct rtw_adapter *padapter, struct led_8723a * pLed);
void SwLedOff23a(struct rtw_adapter *padapter, struct led_8723a * pLed);

--
1.7.10.4

2015-01-17 22:20:18

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8723au: hal: rtl8723au_led.c: Remove some unused functions

On Sun, Dec 21, 2014 at 01:59:39PM +0100, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <[email protected]>
> ---
> drivers/staging/rtl8723au/hal/rtl8723au_led.c | 23 ----------------------
> drivers/staging/rtl8723au/include/rtl8723a_led.h | 2 --
> 2 files changed, 25 deletions(-)

These files aren't even in the tree anymore :(

2015-01-18 16:41:48

by Rickard Strandqvist

Subject: Re: [PATCH] staging: rtl8723au: hal: rtl8723au_led.c: Remove some unused functions

2015-01-17 22:58 GMT+01:00 Greg Kroah-Hartman <[email protected]>:
> On Sun, Dec 21, 2014 at 01:59:39PM +0100, Rickard Strandqvist wrote:
>> Removes some functions that are not used anywhere:
>> rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds()
>>
>> This was partially found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <[email protected]>
>> ---
>> drivers/staging/rtl8723au/hal/rtl8723au_led.c | 23 ----------------------
>> drivers/staging/rtl8723au/include/rtl8723a_led.h | 2 --
>> 2 files changed, 25 deletions(-)
>
> These files aren't even in the tree anymore :(


Hi

No right. I can not find the files.
And can not find these functions anywhere anymore.

Sorry about that :(

Kind regards
Rickard Strandqvist